This repository was archived by the owner on Feb 2, 2022. It is now read-only.
Add in PHP 7.4 #253
Merged
Add in PHP 7.4 #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
amisevsk
approved these changes
Mar 3, 2020
amisevsk
left a comment
amisevsk
left a comment
There was a problem hiding this comment.
👍 as a stop-gap measure but we really need to find a better php base image as this repo should be deprecated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Josh Pinkney joshpinkney@gmail.com
What does this PR do?
This PR adapts the PHP 7.1 Dockerfile to PHP 7.4.
The only difference is that It removes the line
docker-php-ext-configure zip --with-libzipto fix a build error that happens in 7.4 but not in 7.1. Apparently in 7.4 the defaults are sufficient.This PR would supersede #252. (I'm trying to get this fix in before the next release of devfile registry)
What issues does this PR fix or reference?
Needed for eclipse-che/che#15854
Previous behavior
The previous behaviour is that you cannot run
install dependenciesbecause the PHP version is too old. You also cannot revert back to an earlier commit in the devfile because the of security issues that stop the build from finishing.New behavior
Once we update the PHP symphony devfile to use this new image then that devfile will work