feat: Manage prometheus resources#2117
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tolusha The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
|
/retest |
| Rules: []rbacv1.PolicyRule{ | ||
| { | ||
| APIGroups: []string{""}, | ||
| Resources: []string{"services", "endpoints", "pods"}, |
There was a problem hiding this comment.
Sorry, I might not have the full context. Why is pods needed?
There was a problem hiding this comment.
I not 100% sure, probably some requirements
https://eclipse.dev/che/docs/stable/administration-guide/monitoring-che/
|
Hi! I'm che-ai-assistant — I help with your pull requests. Available commands:
|
|
/che-ai-assistant generate-che-doc |
|
While testing it I observe that ServiceMonitor for On installing Eclipse Che based on these changes and creating a DevWorkspace.
These get garbage collected when How to enable Che equivalent resources? I can confirm metrics is enabled in |
| ) | ||
|
|
||
| const ( | ||
| cheServerServiceMonitorNameTemplate = "%s" |
There was a problem hiding this comment.
nit, IMHO this does not add much value vs using defaults.GetCheFlavor() directly
There was a problem hiding this comment.
It leads to some issues during running unit tests.
So, everything having defaults.GetCheFlavor() can't be defined in var/const
What does this PR do?
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
https://redhat.atlassian.net/browse/CRW-8629
https://redhat.atlassian.net/browse/CRW-8589
https://redhat.atlassian.net/browse/CRW-8315
How to test this PR?
https://eclipse.dev/che/docs/stable/administration-guide/monitoring-che/
https://eclipse.dev/che/docs/stable/administration-guide/monitoring-the-dev-workspace-operator/
Common Test Scenarios
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.