This repository was archived by the owner on Aug 25, 2025. It is now read-only.
Converted to plain AsciiDoc#191
Merged
ivargrimstad merged 15 commits intoeclipse-ee4j:masterfrom Jun 30, 2020
Merged
Conversation
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Fix images Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
This was referenced Apr 26, 2020
Closed
Closed
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Member
Author
|
I know everyone's busy with Jakarta EE 9 work, but could someone please take a look and approve this? I'd like to see this landing to master before I continue working on it. |
ivargrimstad
approved these changes
Jun 26, 2020
Member
ivargrimstad
left a comment
There was a problem hiding this comment.
I have no way the bandwidth to review 1005 files, but I trust you when you say that no content has changed and the reorganizing looks excellent to me. Thanks!
Member
Author
|
Thanks Ivar! One more approver and we could merge this please? |
Member
Author
|
@keilw since you are around, would you please have a look at this? |
Member
|
This is really massive, but if it works for you @ggam this looks like the only PR that has no IP problem, so I have a look and might merge it this evening. |
Member
Author
Member
Author
|
Thanks!
El mar., 30 jun. 2020 9:57, Ivar Grimstad <notifications@github.com>
escribió:
… Merged #191 <#191>
into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#191 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQC44AXCE4S57AXLC53NKTRZGLFLANCNFSM4MQMPHDQ>
.
|
Member
|
I saw @ivargrimstad already merged it, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts the whole tutorial to plain AsciiDoc without JBake. The result can be seen at http://www.ggam.eu/jakartaee-tutorial/
I haven't made any content changes besides removing duplicated titles that weren't needed anymore. To the best of my knowledge, all links and images are still working and this PR is in a mergeable state.
This makes the tutorial easier to maintain and provides a more modern look.
Things I've made:
Closes:
And makes it straightforward to solve #129.