Skip to content

Conversation

@msohn
Copy link

@msohn msohn commented Jul 8, 2025

No description provided.

@merks
Copy link

merks commented Jul 9, 2025

I’m not a committer here.

@HannesWell or @opcoach can.

But of course we’re in meetings all day today.

@HannesWell
Copy link
Contributor

Thank you for providing this, I'll have a look at it this evening or in the next days.

@HannesWell
Copy link
Contributor

Sorry to not responding earlier. Currently this change does not exactly follow the schema of the other entries.
I'll unify it, but won't have time for it before the end of next week, but will then also look to provide entries of other large SimRel projects.

Copy link
Contributor

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to not responding earlier. Currently this change does not exactly follow the schema of the other entries.
I'll unify it, but won't have time for it before the end of next week, but will then also look to provide entries of other large SimRel projects.

Again sorry for the subsequent delay.
I have now tried to align this change a bit better to the existing entries, although the joint setup for EGit and JGit hinders this a bit. But I think the current state is ok.

Is there a specific reason why there is only on project for both, JGit and EGit? Besides that it just wasn't split yet?
I assume that both projects share a lot of their setup, but can one develop them independently of each other? Or is it strictly required to always have both in the workspace?
If not, we could at least provide different sub-projects for EGit and JGit respectively with own streams, similar like it's for example done in eclipse-platform (I can do that if you want to have it):

It would sill be possible to maintain both projects in one setup file (in egit).

But besides this organizational question, the setup you provide is just the project from the catalog and one cannot apply this to the installer:

What's actually needed for this is a configuration (defining in the Oomph model an installation from a product and a workspace from a project).

For example m2e provides this in
https://github.com/eclipse-m2e/m2e-core/blob/cccacb01daca5c2e6c6757b13a9d5c0f2292ccd5/setup/m2eDevelopmentEnvironmentConfiguration.setup
referencing the project defined in
https://github.com/eclipse-m2e/m2e-core/blob/cccacb01daca5c2e6c6757b13a9d5c0f2292ccd5/setup/m2e.setup

@msohn I can create that required Oomph configuration for you can contribute it to the EGit repository (and JGit repo if applicable). But I would like to know first if it make sense to have a separate one for EGit and JGit or if it should definitively be a joint one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants