Skip to content

feat: update Keyple BOM version to 2025.11.21 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeanpierrefortune merged 3 commits into from
Nov 27, 2025
Merged

feat: update Keyple BOM version to 2025.11.21 #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23fda3d
feat: update Keyple BOM version to 2025.11.21
jeanpierrefortune Nov 26, 2025
634a2de
Refactor transaction handling to simplify response retrieval
jeanpierrefortune Nov 27, 2025
ee15045
Fix changelog wording for Keyple Java BOM upgrade.
jeanpierrefortune Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## [Unreleased]

### Upgraded
- Upgraded [Keyple Java BOM](https://github.com/eclipse-keyple/keyple-java-bom) to `2025.11.21`.

## [2025-10-29]
### Changed
- Switched to [Keyple Java BOM](https://github.com/eclipse-keyple/keyple-java-bom) `2025.10.24` for dependency
Expand Down
4 changes: 3 additions & 1 deletion build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ plugins {
dependencies {
// Begin Keyple configuration (generated by
// 'https://keyple.org/components/overview/configuration-wizard/')
testImplementation(platform("org.eclipse.keyple:keyple-java-bom:2025.10.24"))
testImplementation(platform("org.eclipse.keyple:keyple-java-bom:2025.11.21"))
testImplementation("org.eclipse.keypop:keypop-reader-java-api")
testImplementation("org.eclipse.keypop:keypop-calypso-card-java-api")
testImplementation("org.eclipse.keypop:keypop-calypso-crypto-legacysam-java-api")
Expand Down Expand Up @@ -76,6 +76,8 @@ fun copyLicenseFiles() {
noticeFile.copyTo(File(metaInfDir, "NOTICE.md"), overwrite = true)
}

tasks.withType<JavaCompile> { options.compilerArgs.add("-Xlint:deprecation") }

tasks {
spotless {
java {
Expand Down
8 changes: 5 additions & 3 deletions ...lipse/keyple/distributed/integration/readerclientside/app/RemotePluginServerObserver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
package org.eclipse.keyple.distributed.integration.readerclientside.app;

import java.util.List;
import org.eclipse.keyple.card.generic.ChannelControl;
import org.eclipse.keyple.card.generic.GenericCardSelectionExtension;
import org.eclipse.keyple.card.generic.GenericExtensionService;
import org.eclipse.keyple.core.service.Plugin;
Expand All @@ -27,6 +26,7 @@
import org.eclipse.keyple.distributed.integration.readerclientside.model.InputDataDto;
import org.eclipse.keyple.distributed.integration.readerclientside.model.OutputDataDto;
import org.eclipse.keypop.reader.CardReader;
import org.eclipse.keypop.reader.ChannelControl;
import org.eclipse.keypop.reader.ReaderApiFactory;
import org.eclipse.keypop.reader.selection.CardSelectionManager;
import org.eclipse.keypop.reader.selection.CardSelectionResult;
Expand Down Expand Up @@ -82,7 +82,8 @@ Object executeService(Plugin plugin, CardReader reader) {
GenericExtensionService.getInstance()
.createCardTransaction(reader, card)
.prepareApdu("0000000000")
.processApdusToHexStrings(ChannelControl.CLOSE_AFTER);
.processCommands(ChannelControl.CLOSE_AFTER)
.getResponsesAsHexStrings();
return new OutputDataDto().setUserId(inputDataDto.getUserId()).setSuccessful(true);
} catch (RuntimeException e) {
if (e instanceof StubNetworkConnectionException) {
Expand All @@ -104,7 +105,8 @@ Object executeService(Plugin plugin, CardReader reader) {
GenericExtensionService.getInstance()
.createCardTransaction(reader, card)
.prepareApdu("0000000000")
.processApdusToHexStrings(ChannelControl.CLOSE_AFTER);
.processCommands(ChannelControl.CLOSE_AFTER)
.getResponsesAsHexStrings();
return new OutputDataDto().setUserId(inputDataDto.getUserId()).setSuccessful(true);
} catch (RuntimeException e) {
if (e instanceof StubNetworkConnectionException) {
Expand Down