"Normalize" ExpandedNodeId returned by browse services #1468
+160
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce `BrowseUtil.normalize` to handle normalization of `ExpandedNodeId` values, ensuring they are relative for local nodes and absolute for non-local nodes. - Replaced existing normalization logic across `BrowseHelper` and `BrowsePathsHelper` with calls to `BrowseUtil.normalize`. fixes #1467
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR unifies the normalization of ExpandedNodeId values by introducing the BrowseUtil.normalize method and replacing existing inline normalization logic.
- Introduces a new helper method in BrowseUtil to handle normalization.
- Updates BrowseHelper and BrowsePathsHelper to use the new utility method.
- Adds BrowseUtilTest to verify the expected behavior of normalization for both local and non-local cases.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| BrowseUtilTest.java | Added tests to validate normalization logic for both local and non-local ExpandedNodeId cases. |
| BrowseUtil.java | Added a new static normalize method that consolidates normalization logic for ExpandedNodeId. |
| BrowsePathsHelper.java | Replaced inline normalization logic with a call to BrowseUtil.normalize in mapping BrowsePathTarget. |
| BrowseHelper.java | Refactored normalization in creating ReferenceDescription and in determining type definitions to use BrowseUtil.normalize. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BrowseUtil.normalizeto handle normalization ofExpandedNodeIdvalues, ensuring they are relative for local nodes and absolute for non-local nodes.BrowseHelperandBrowsePathsHelperwith calls toBrowseUtil.normalize.fixes #1467