Skip to content

Fix flaky test QuickAccessComputerTest.testQuickAccessComputer #3641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vogella merged 2 commits into from
Jan 6, 2026
+2 −2
Merged

Fix flaky test QuickAccessComputerTest.testQuickAccessComputer #3641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec4b45c
Fix flaky test QuickAccessComputerTest.testQuickAccessComputer
vogella Jan 6, 2026
ebe65c5
Version bump(s) for 4.39 stream
eclipse-platform-bot Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/org.eclipse.text.quicksearch.tests/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.text.quicksearch.tests
Bundle-Version: 1.3.100.qualifier
Bundle-Version: 1.3.200.qualifier
Require-Bundle: org.eclipse.core.runtime,
org.eclipse.text.quicksearch;bundle-version="1.0.300",
org.eclipse.core.resources,
Expand Down
2 changes: 1 addition & 1 deletion ...ext.quicksearch.tests/src/org/eclipse/text/quicksearch/tests/QuickAccessComputerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ void testQuickAccessComputer() throws CoreException, IOException {
dialog.setBlockOnOpen(false);
dialog.open();
var display = dialog.getShell().getDisplay();
assertTrue(DisplayHelper.waitForCondition(display, 2000, () -> dialog.getResult().length > 0));
assertTrue(DisplayHelper.waitForCondition(display, 5000, () -> dialog.getResult().length > 0), "QuickSearchDialog failed to find results within timeout");
dialog.close();

// Wait for the QuickAccessComputer to return results, as the search happens asynchronously.
Expand Down
Loading