Skip to content

Do not enable Link Prototypes if there are no prototypes #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SougandhS wants to merge 1 commit into
base: master
Choose a base branch
from
+25 −25
Open

Do not enable Link Prototypes if there are no prototypes #2216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 25 additions & 25 deletions ...e.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LinkPrototypeAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@
*******************************************************************************/
package org.eclipse.debug.internal.ui.launchConfigurations;

import java.util.Collection;
import java.util.HashSet;

import org.eclipse.core.runtime.CoreException;
import org.eclipse.debug.core.ILaunchConfiguration;
import org.eclipse.debug.core.ILaunchConfigurationType;
Expand Down Expand Up @@ -104,34 +101,37 @@ protected void performAction() {
*/
@Override
protected boolean updateSelection(IStructuredSelection selection) {
// Enable action only if launch configuration(s) of the same type
// is(are) selected and the launch configuration type allows prototypes
Collection<ILaunchConfigurationType> launchConfigurationTypes = new HashSet<>();
if (selection.isEmpty()) {
return false;
}
ILaunchConfigurationType type = null;
for (Object object : selection.toList()) {
if (object instanceof ILaunchConfiguration) {
if (((ILaunchConfiguration) object).isPrototype()) {
if (!(object instanceof ILaunchConfiguration launchConfig)) {
return false;
}

if (launchConfig.isPrototype()) {
return false;
}

ILaunchConfigurationType currentType;
try {
currentType = launchConfig.getType();
if (currentType.getPrototypes().length == 0) {
return false;
} else {
ILaunchConfigurationType type = null;
try {
type = ((ILaunchConfiguration) object).getType();
} catch (CoreException e) {
DebugUIPlugin.log(e.getStatus());
}
if (type != null) {
launchConfigurationTypes.add(type);
} else {
return false;
}
}
} else {
} catch (CoreException e) {
DebugUIPlugin.log(e.getStatus());
return false;
}

if (type == null) {
type = currentType;
} else if (!type.equals(currentType)) {
return false;
}
}
if (launchConfigurationTypes.size() == 1) {
return launchConfigurationTypes.iterator().next().supportsPrototypes();
}
return false;
return true;
}

@Override
Expand Down
Loading