Refactorings needed for injection support by eclipse-impl · Pull Request #186 · eclipse-score/baselibs

eclipse-impl · 2026-05-08T13:53:06Z

Different SCORE users might have specific needs for supporting proprietary or copyrighted hashing functions. Therefore we need to provide the mechanism for clients injecting their extensions to the hash lib.

This commit prepares the open-source code for the injection of a copyrighted hash function by one of the clients.

Notice that the aim is to achieve a design that will be sufficiently generic that will allow for extensions without any change on the open-source side.

github-actions · 2026-05-08T14:01:27Z

The created documentation from the pull request is available at: docu-html

Copilot

Pull request overview

This PR prepares the SCORE hash library for client-side extension/injection of hashing functionality (including proprietary implementations) by widening Bazel visibility and introducing clearer extension points around CRC variants.

Changes:

Expose selected hash-related Bazel targets publicly to enable external composition/overrides.
Refactor CRC32 IEEE implementation to share a reusable compile-time lookup table and remove custom.bzl hooks.
Rename HashAlgorithm::kCrc32Unused to HashAlgorithm::kCrc32Autosar and update factories/tests/logging accordingly.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
score/hash/code/sha256digest/BUILD	Makes sha256digest library publicly visible for external wiring.
score/hash/code/openssl/openssl_wrapper/BUILD	Makes OpenSSL mock target publicly visible (for external tests).
score/hash/code/openssl/openssl_hash_calculator.cpp	Updates unsupported algorithm switch cases for renamed CRC enum.
score/hash/code/openssl/BUILD	Makes OpenSSL calculator library publicly visible for injection scenarios.
score/hash/code/crc/lookup_table.h	Adds shared constexpr CRC lookup table implementation.
score/hash/code/crc/custom.bzl	Removes no-op custom hook file.
score/hash/code/crc/crc32_ieee.cpp	Switches CRC32 IEEE to use shared lookup table header.
score/hash/code/crc/BUILD	Exposes CRC IEEE library publicly and documents extension approach.
score/hash/code/core/factory/impl/safe_hash_calculator_factory_ieee.cpp	Updates unsupported algorithm cases for renamed CRC enum.
score/hash/code/core/factory/impl/hash_calculator_factory_ieee.cpp	Updates unsupported algorithm cases for renamed CRC enum.
score/hash/code/core/factory/impl/hash_calculator_factory_ieee_test.cpp	Updates test to use renamed CRC algorithm (but test name still says “Unused”).
score/hash/code/core/factory/impl/custom.bzl	Removes no-op custom hook file.
score/hash/code/core/factory/impl/BUILD	Adds a public header-only target and updates extension-point documentation.
score/hash/code/common/algorithms.h	Renames CRC enum value and size constant; updates logging string.
score/hash/code/common/algorithms.cpp	Updates size mapping and identification comments for renamed CRC enum.
score/hash/code/common/algorithms_test.cpp	Updates tests for renamed CRC enum and log output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+#include <cstdint>
+
+namespace score
+{
+namespace hash
+{
+namespace internal
+{
+
+/// @brief Compile-time CRC32 lookup table parameterised by a reflected polynomial.
+///
+/// This is an implementation detail shared by CRC32 calculator classes.
+/// It is not part of the public API.
+template <std::uint_fast32_t ReversePolynomial>
+class LookupTable final
+{
+  public:
+    constexpr LookupTable() : table_{}
+    {
+        for (std::uint_fast32_t table_index = 0U; table_index < kTableSize; ++table_index)
+        {
+            auto checksum = table_index;
+
+            for (auto round = 0U; round < 8U; ++round)
+            {
+                if (static_cast<bool>(checksum & 0x1U))
+                {
+                    checksum = (checksum >> 1U) ^ ReversePolynomial;
+                }
+                else
+                {
+                    checksum = (checksum >> 1U) ^ 0U;
+                }
+            }
+            // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-constant-array-index) can't use .at() in constexpr fn
+            table_[table_index] = checksum;
+        }
+    }
+
+    constexpr std::uint_fast32_t operator[](size_t i) const noexcept
+    {
+        // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-constant-array-index) can't use .at() in constexpr fn
+        return table_[i];


+# If one needs to provide different polynomials, one can directly inherit
+# from this target and use the `label_flag` at:
+# score/hash/code/core/factory/impl/BUILD
+# For providing the extended version as a replacement for `(safe_)crc_variant`.


+# meaning that one may replace them by custom implementations that would
+# provide different polynomials. These extensions may directly inherit from:
+# //score/hash/code/crc:crc_ieee
+# As that target provides a generic implementation of CRC, the custom
+# implementations would then only need to provide their polynomials
+# and override these two targets on their .bazelrc files.


    score::cpp::span<const std::uint8_t> data(test_input);

-    auto result = unit.CalculateHash(HashAlgorithm::kCrc32Unused, data);
+    auto result = unit.CalculateHash(HashAlgorithm::kCrc32Autosar, data);


eclipse-impl · 2026-05-26T14:47:04Z

    kSha512,
    kCrc32,
-    kCrc32Unused,
+    kCrc32Autosar,


There are currently no users for the API, so it's fine to break it.

Different SCORE users might have specific needs for supporting proprietary or copyrighted hashing functions. Therefore we need to provide the mechanism for clients injecting their extensions to the hash lib. This commit prepares the open-source code for the injection of a copyrighted hash function by one of the clients. Notice that the aim is to achieve a design that will be sufficiently generic that will allow for extensions without any change on the open-source side.

github-project-automation Bot added this to BAS - Baselibs FT May 8, 2026

github-project-automation Bot moved this to In Progress in BAS - Baselibs FT May 8, 2026

eclipse-impl temporarily deployed to workflow-approval May 8, 2026 13:53 — with GitHub Actions Inactive

eclipse-impl requested a deployment to workflow-approval May 12, 2026 12:02 — with GitHub Actions Waiting

eclipse-impl force-pushed the swp-260766 branch from f1a8c84 to 8319fa7 Compare May 12, 2026 12:07

eclipse-impl requested a deployment to workflow-approval May 12, 2026 12:07 — with GitHub Actions Waiting

eclipse-impl force-pushed the swp-260766 branch from 8319fa7 to 5196bc4 Compare May 12, 2026 12:20

eclipse-impl temporarily deployed to workflow-approval May 12, 2026 12:20 — with GitHub Actions Inactive

eclipse-impl marked this pull request as ready for review May 12, 2026 12:20

eclipse-impl requested review from 4og and antonkri as code owners May 12, 2026 12:20

eclipse-impl requested a deployment to workflow-approval May 15, 2026 07:15 — with GitHub Actions Waiting

eclipse-impl force-pushed the swp-260766 branch from ee395f7 to 34ad4b6 Compare May 15, 2026 09:28

eclipse-impl requested a deployment to workflow-approval May 15, 2026 09:28 — with GitHub Actions Waiting

eclipse-impl force-pushed the swp-260766 branch from 34ad4b6 to 25c5442 Compare May 15, 2026 09:31

eclipse-impl temporarily deployed to workflow-approval May 15, 2026 09:31 — with GitHub Actions Inactive

eclipse-impl requested a deployment to workflow-approval May 15, 2026 09:45 — with GitHub Actions Waiting

eclipse-impl force-pushed the swp-260766 branch from 8e427c3 to a860e47 Compare May 15, 2026 09:46

eclipse-impl requested a deployment to workflow-approval May 15, 2026 09:46 — with GitHub Actions Waiting

eclipse-impl force-pushed the swp-260766 branch from a860e47 to 2e6ec5f Compare May 15, 2026 10:17

eclipse-impl temporarily deployed to workflow-approval May 15, 2026 10:17 — with GitHub Actions Inactive

4og added the comp-hash Related to score/hash component label May 15, 2026

4og requested a review from Copilot May 26, 2026 12:58

Copilot started reviewing on behalf of 4og May 26, 2026 12:58 View session

Copilot AI reviewed May 26, 2026

View reviewed changes

eclipse-impl requested a deployment to workflow-approval May 26, 2026 14:48 — with GitHub Actions Waiting

eclipse-impl force-pushed the swp-260766 branch from b5d9e04 to c77e2c0 Compare May 27, 2026 12:32

eclipse-impl requested a deployment to workflow-approval May 27, 2026 12:32 — with GitHub Actions Waiting

eclipse-impl force-pushed the swp-260766 branch from c77e2c0 to fc2a8df Compare May 27, 2026 16:16

eclipse-impl requested a deployment to workflow-approval May 27, 2026 16:16 — with GitHub Actions Waiting

eclipse-impl force-pushed the swp-260766 branch from fc2a8df to fa29d22 Compare May 28, 2026 07:59

eclipse-impl requested a deployment to workflow-approval May 28, 2026 07:59 — with GitHub Actions Waiting

eclipse-impl force-pushed the swp-260766 branch from fa29d22 to 76c008d Compare May 28, 2026 08:01

eclipse-impl requested a deployment to workflow-approval May 28, 2026 08:01 — with GitHub Actions Waiting

eclipse-impl requested a deployment to workflow-approval May 28, 2026 08:09 — with GitHub Actions Waiting

eclipse-impl force-pushed the swp-260766 branch from 105edd7 to b5ebc40 Compare May 28, 2026 08:11

eclipse-impl requested a deployment to workflow-approval May 28, 2026 08:11 — with GitHub Actions Waiting

eclipse-impl force-pushed the swp-260766 branch from b5ebc40 to 7d98047 Compare May 29, 2026 09:59

eclipse-impl deployed to workflow-approval May 29, 2026 09:59 — with GitHub Actions Active

eclipse-impl temporarily deployed to workflow-approval May 29, 2026 09:59 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactorings needed for injection support#186

Refactorings needed for injection support#186
eclipse-impl wants to merge 1 commit into
eclipse-score:mainfrom
eclipse-impl:swp-260766

eclipse-impl commented May 8, 2026

Uh oh!

github-actions Bot commented May 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

eclipse-impl May 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

eclipse-impl commented May 8, 2026

Uh oh!

github-actions Bot commented May 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

eclipse-impl May 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants