-
Notifications
You must be signed in to change notification settings - Fork 20
Fix compatibility with rules_python >= 1.5.0 #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix compatibility with rules_python >= 1.5.0 #337
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //src:license-checkStatus: Click to expand output |
142f7a0 to
2842244
Compare
|
Tough problem. The log does not contain any helpful info. Locally, |
|
The created documentation from the pull request is available at: docu-html |
|
I'm always weary of changing the runffiles thing, we had such big issues with that in the past. |
f5ce59e to
5e0cf4c
Compare
You are probably right to be weary. I thought it was ready because the workflows were green and thought some change on main fixed the underlying issue but it seems it did not. I tried a local build and it still fails. But what to do with that? We are still incompatible and I still have no idea what could be the issue because the error messages are not helpful. Is our toolchain maybe too complex and we should re-think the complete approach? |
📌 Description
rules_python1.5.0 broke the way the package discovers the plantuml tool resulting in errorswhen building the
:needs_jsontarget.This PR fixes #295
🚨 Impact Analysis
✅ Checklist