Skip to content

Conversation

@NEOatNHNG
Copy link
Contributor

📌 Description

rules_python 1.5.0 broke the way the package discovers the plantuml tool resulting in errors
when building the :needs_json target.

This PR fixes #295

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 76f0b0a5-a1dc-49e0-8be0-f9bf610d6b58
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (72 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (123 packages loaded, 2485 targets configured)

Analyzing: target //src:license-check (134 packages loaded, 2675 targets configured)

Analyzing: target //src:license-check (137 packages loaded, 4648 targets configured)

INFO: Analyzed target //src:license-check (137 packages loaded, 4691 targets configured).
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 14.606s, Critical Path: 0.23s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@a-zw
Copy link
Contributor

a-zw commented Jan 9, 2026

Tough problem. The log does not contain any helpful info. Locally, bazel run //:docs_check executes successfully for me.

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

@MaximilianSoerenPollak
Copy link
Contributor

I'm always weary of changing the runffiles thing, we had such big issues with that in the past.
It might have unintended consequences though things seem to work well and pass the tests.

@NEOatNHNG NEOatNHNG marked this pull request as draft January 22, 2026 12:32
@NEOatNHNG NEOatNHNG force-pushed the fix/compatibility-with-rules_python-1.5.0 branch from f5ce59e to 5e0cf4c Compare January 22, 2026 12:37
@NEOatNHNG
Copy link
Contributor Author

I'm always weary of changing the runffiles thing, we had such big issues with that in the past. It might have unintended consequences though things seem to work well and pass the tests.

You are probably right to be weary. I thought it was ready because the workflows were green and thought some change on main fixed the underlying issue but it seems it did not. I tried a local build and it still fails.

But what to do with that? We are still incompatible and I still have no idea what could be the issue because the error messages are not helpful. Is our toolchain maybe too complex and we should re-think the complete approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Draft

Development

Successfully merging this pull request may close these issues.

Build failed with updated dependency rules_python >= 1.5.0

3 participants