perf: Split metamodel test#568
Open
a-zw wants to merge 3 commits into
Open
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
This costs ~700ms x 15+ tests. Also, network access is not a good thing for tests.
63155f2 to
312283f
Compare
|
The created documentation from the pull request is available at: docu-html |
| data = glob( | ||
| [ | ||
| "tests/**/*.rst", | ||
| "tests/**/*.yaml", |
Contributor
There was a problem hiding this comment.
Do not forget to also add the .yaml file, one tests needs that.
Contributor
Author
There was a problem hiding this comment.
The tests are all passing. Maybe you think of test_metamodel_load.py? That one is part of :unit_tests.
MaximilianSoerenPollak
requested changes
May 29, 2026
Contributor
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
Only 2 comments.
The size thing is irrelevant for this PR and something we need to address overall
3c015f3 to
a862bea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting up the slowest test for better caching. Also, removing needs.json downloads.
📌 Description
🚨 Impact Analysis
✅ Checklist