CW_21 export by Y-Vaishnavi · Pull Request #129 · eclipse-score/logging

Y-Vaishnavi · 2026-05-28T10:54:29Z

Notes for Reviewer

Pre-Review Checklist for the PR Author

PR title is short, expressive and meaningful
Commits are properly organized
Relevant issues are linked in the References section
Tests are conducted
Unit tests are added

Checklist for the PR Reviewer

Commits are properly organized and messages are according to the guideline
Unit tests have been written for new behavior
Public API is documented
PR title describes the changes

Post-review Checklist for the PR Author

All open points are addressed and tracked via issues

References

Closes #

github-actions · 2026-05-28T10:55:10Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: c9b9e05f-5222-41eb-8fd6-1e9000f5dcdb
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.8.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.9.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.2.17 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@2.3.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version buildifier_prebuilt@7.3.1, but got buildifier_prebuilt@8.5.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_tooling', the root module requires module version score_tooling@1.1.2, but got score_tooling@1.2.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.3, but got score_rust_policies@0.0.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_crates', the root module requires module version score_crates@0.0.6, but got score_crates@0.0.9 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0.bcr.1, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rapidjson', the root module requires module version rapidjson@1.1.0, but got rapidjson@1.1.0.bcr.20241007 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 5.269s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

github-actions · 2026-05-28T10:56:32Z

The created documentation from the pull request is available at: docu-html

rmaddikery · 2026-05-29T05:19:29Z


 load("@rules_cc//cc:defs.bzl", "cc_library")
 load("@score_baselibs//score/language/safecpp:toolchain_features.bzl", "COMPILER_WARNING_FEATURES")
-load("@score_baselibs//score/quality/clang_tidy:extra_checks.bzl", "clang_tidy_extra_checks")


why are these removed?

These clang_tidy_extra_checks blocks are removed in the internal repo only

Alright, confirmed that these will be handled centrally and subdir do not need a seperate rule list

(parameter-tools): introduce meaningful parser exceptions, centralize duplicate component-name validation, and simplify error handling flow GIT_ORIGIN_SPP_REV_ID: 2d835d9a55761abfe4b9a6b9fca4361f51eeebb3

- M8-4-2 violations in ara/log/src/logger.cpp (lines 136, 153) --> Variables name were changed. - A15-4-2 violation in mw/log/detail/data_router/data_router_message_client_impl.cpp (line 316) --> Suppression added. - A18-5-8 violation in mw/log/detail/registry_aware_recorder_factory.cpp (line 122) --> Fix applied - A18-9-2 violation in mw/log/detail/wait_free_producer_queue/alternating_reader_proxy.cpp --> use std::move() - M5-0-4 violations in mw/log/detail/wait_free_producer_queue/alternating_reader_proxy.cpp GIT_ORIGIN_SPP_REV_ID: 62127a5b8593164f895fec2d59318a71629aaa1c

- Suppress autosar_cpp14_m0_1_3_violation and autosar_cpp14_m0_1_9_violation because these variables are already used GIT_ORIGIN_SPP_REV_ID: 8bde46f656b31ea0361fd1ee04ebcfe89dd67d62

Fix Copybara transformation rules and BUILD dependencies to resolve build errors in the OSS eclipse-score-logging mirror. fix: backend copybara rule GIT_ORIGIN_SPP_REV_ID: 77336b76f79be5d7c25bbd2fa30ea2116dcc0331

Y-Vaishnavi requested a deployment to workflow-approval May 28, 2026 10:54 — with GitHub Actions Waiting

Y-Vaishnavi requested a deployment to workflow-approval May 28, 2026 11:17 — with GitHub Actions Waiting

Y-Vaishnavi force-pushed the 5A6A3ABB4B74F4375B4D7C51733A2996 branch from 11a69d5 to a248e02 Compare May 28, 2026 11:21

Y-Vaishnavi requested a deployment to workflow-approval May 28, 2026 11:21 — with GitHub Actions Waiting

Y-Vaishnavi closed this May 28, 2026

Y-Vaishnavi reopened this May 28, 2026

Y-Vaishnavi requested a deployment to workflow-approval May 28, 2026 11:29 — with GitHub Actions Waiting

Y-Vaishnavi force-pushed the 5A6A3ABB4B74F4375B4D7C51733A2996 branch from a248e02 to e3dd666 Compare May 28, 2026 11:38

Y-Vaishnavi requested a deployment to workflow-approval May 28, 2026 11:38 — with GitHub Actions Waiting

rmaddikery reviewed May 28, 2026

View reviewed changes

Comment thread score/mw/log/detail/file_recorder/BUILD

rmaddikery reviewed May 28, 2026

View reviewed changes

Comment thread score/mw/log/detail/slog/BUILD

rmaddikery reviewed May 28, 2026

View reviewed changes

Comment thread score/mw/log/detail/utils/signal_handling/BUILD

rmaddikery reviewed May 28, 2026

View reviewed changes

Comment thread score/mw/log/legacy_non_verbose_api/BUILD

Y-Vaishnavi force-pushed the 5A6A3ABB4B74F4375B4D7C51733A2996 branch from e3dd666 to 3727eeb Compare May 28, 2026 16:37

Y-Vaishnavi requested a deployment to workflow-approval May 28, 2026 16:37 — with GitHub Actions Waiting

Y-Vaishnavi requested a review from rmaddikery May 29, 2026 04:38

rmaddikery reviewed May 29, 2026

View reviewed changes

Jianjun Wen and others added 5 commits May 29, 2026 12:55

Refactor exception handling logic in calib tools

188c1a8

(parameter-tools): introduce meaningful parser exceptions, centralize duplicate component-name validation, and simplify error handling flow GIT_ORIGIN_SPP_REV_ID: 2d835d9a55761abfe4b9a6b9fca4361f51eeebb3

Fix Coverity Warnings in mw::log::detail

9e8ea76

- Suppress autosar_cpp14_m0_1_3_violation and autosar_cpp14_m0_1_9_violation because these variables are already used GIT_ORIGIN_SPP_REV_ID: 8bde46f656b31ea0361fd1ee04ebcfe89dd67d62

fix: Copybara export fixes for OSS logging build errors

fa16b48

Fix Copybara transformation rules and BUILD dependencies to resolve build errors in the OSS eclipse-score-logging mirror. fix: backend copybara rule GIT_ORIGIN_SPP_REV_ID: 77336b76f79be5d7c25bbd2fa30ea2116dcc0331

fix: Add missing copyright headers

49f0a4a

Y-Vaishnavi force-pushed the 5A6A3ABB4B74F4375B4D7C51733A2996 branch from 3727eeb to 49f0a4a Compare May 29, 2026 07:26

Y-Vaishnavi temporarily deployed to workflow-approval May 29, 2026 07:26 — with GitHub Actions Inactive

Y-Vaishnavi deployed to workflow-approval May 29, 2026 07:26 — with GitHub Actions Active

Y-Vaishnavi requested a review from rmaddikery May 29, 2026 07:55

Y-Vaishnavi marked this pull request as ready for review May 29, 2026 07:57

Y-Vaishnavi requested review from 4og and antonkri as code owners May 29, 2026 07:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CW_21 export #129

CW_21 export #129
Y-Vaishnavi wants to merge 5 commits into
eclipse-score:mainfrom
Y-Vaishnavi:5A6A3ABB4B74F4375B4D7C51733A2996

Y-Vaishnavi commented May 28, 2026

Uh oh!

github-actions Bot commented May 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rmaddikery May 29, 2026

Uh oh!

Y-Vaishnavi May 29, 2026 •

edited

Loading

Uh oh!

rmaddikery May 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Y-Vaishnavi commented May 28, 2026

Notes for Reviewer

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

References

Uh oh!

github-actions Bot commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions Bot commented May 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rmaddikery May 29, 2026

Choose a reason for hiding this comment

Uh oh!

Y-Vaishnavi May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rmaddikery May 29, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented May 28, 2026 •

edited

Loading

Y-Vaishnavi May 29, 2026 •

edited

Loading