Skip to content

bazel: fix "cc_*" is not global anymore #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
arkjedrz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bazel: fix "cc_*" is not global anymore #24

arkjedrz wants to merge 1 commit into from

Conversation

@arkjedrz
Copy link
Contributor

@arkjedrz arkjedrz commented Jan 7, 2026 •
edited by pawelrutkaq
Loading

Load required cc_* functions.

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • PR title is short, expressive and meaningful
  • Commits are properly organized
  • Relevant issues are linked in the References section
  • Tests are conducted
  • Unit tests are added

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #

@arkjedrz arkjedrz temporarily deployed to workflow-approval January 7, 2026 16:39 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 7, 2026 •
edited
Loading

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 5cd59d95-a6d3-4143-ba57-a8a861e86c95
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-eQOopREOYCL5vtTb6c1cwZrql4GVrJ1FqgxarQRe1xs="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.5.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.8.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.2.8 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@1.10.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version buildifier_prebuilt@7.3.1, but got buildifier_prebuilt@8.2.0.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0.bcr.1, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 23.474s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@arkjedrz arkjedrz mentioned this pull request Jan 7, 2026
Merged
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

The created documentation from the pull request is available at: docu-html

@arkjedrz arkjedrz requested a review from rmaddikery January 7, 2026 16:48
pawelrutkaq
pawelrutkaq previously approved these changes Jan 8, 2026
View reviewed changes
rmaddikery
rmaddikery suggested changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@rmaddikery rmaddikery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets discuss the review in Logging in CFT

rmaddikery
rmaddikery suggested changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@rmaddikery rmaddikery left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets please discuss the review in the Logging CFT since the changes in mw/log affects sync in reference integration

@pawelrutkaq
Copy link
Contributor

pawelrutkaq commented Jan 8, 2026 •
edited
Loading

Lets discuss the review in Logging in CFT please since he changes in mw/log affects sync in reference integration

Can you please clarify what do you mean ? Generally, we shall not always wait to next CFT meeting to do something with PR but continue here until possible or do fast ad-hoc call ;)

@rmaddikery
Copy link
Contributor

rmaddikery commented Jan 8, 2026

Lets discuss the review in Logging in CFT please since he changes in mw/log affects sync in reference integration

Can you please clarify what do you mean ? Generally, we shall not always wait to next CFT meeting to do something with PR but continue here until possible or do fast ad-hoc call ;)

Our codebase includes sections synchronized with contributions to score through automated bidirectional sync. Changes to these areas require approval from original code authors to prevent sync failures. While we're improving this process, CODEOWNERS are not yet configured for these directories. Given this is a beta contribution, we suggest aligning on the approach in the CFT review before implementation.

@pawelrutkaq
Copy link
Contributor

pawelrutkaq commented Jan 8, 2026

Lets discuss the review in Logging in CFT please since he changes in mw/log affects sync in reference integration

Can you please clarify what do you mean ? Generally, we shall not always wait to next CFT meeting to do something with PR but continue here until possible or do fast ad-hoc call ;)

Our codebase includes sections synchronized with contributions to score through automated bidirectional sync. Changes to these areas require approval from original code authors to prevent sync failures. While we're improving this process, CODEOWNERS are not yet configured for these directories. Given this is a beta contribution, we suggest aligning on the approach in the CFT review before implementation.

So You dont mean refernce_integration repo but copybara. ok lets align in CFT.

rmaddikery
rmaddikery reviewed Jan 8, 2026
View reviewed changes
Copy link
Contributor

@rmaddikery rmaddikery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what issue you encounter without the redundant load statements?

score/datarouter/BUILD
# SPDX-License-Identifier: Apache-2.0
# *******************************************************************************

load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library")
Copy link
Contributor

@rmaddikery rmaddikery Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIU, this load statement is redundant since rules_cc is declared as a bazel_dep

logging/MODULE.bazel

Line 23 in a37a044

bazel_dep(name = "rules_cc", version = "0.1.1")
which makes cc_library and cc_binary available global

Copy link
Contributor Author

@arkjedrz arkjedrz Jan 19, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying comment from @PiotrKorkus
Original PR: #21

@rmaddikery Please take a look into official C++ bazel example - https://github.com/bazelbuild/examples/blob/main/cpp-tutorial/stage1/main/BUILD

First versions of bazel did not require load statement for cc_binary / library but since 2019, there is a hint to use it as it will be a future incompatibility already.

Please not wait until deprecated, especially since those warnings increase noise level.

@arkjedrz arkjedrz self-assigned this Jan 14, 2026
@arkjedrz arkjedrz force-pushed the arkjedrz_fix-buildifier-issues branch from 1caf212 to 00ba38a Compare January 15, 2026 09:57
@arkjedrz arkjedrz temporarily deployed to workflow-approval January 15, 2026 09:57 — with GitHub Actions Inactive
@arkjedrz arkjedrz requested a review from rmaddikery January 19, 2026 12:12
@arkjedrz arkjedrz force-pushed the arkjedrz_fix-buildifier-issues branch from 00ba38a to cdb88f5 Compare January 21, 2026 10:02
@arkjedrz arkjedrz temporarily deployed to workflow-approval January 21, 2026 10:02 — with GitHub Actions Inactive
@arkjedrz arkjedrz requested a review from pawelrutkaq January 21, 2026 10:03
@arkjedrz @pawelrutkaq
bazel: fix "cc_*" is not global anymore
ad7e65a 
Load required `cc_*` functions.
@pawelrutkaq pawelrutkaq force-pushed the arkjedrz_fix-buildifier-issues branch from cdb88f5 to ad7e65a Compare January 22, 2026 08:20
pawelrutkaq
pawelrutkaq requested changes Jan 22, 2026
View reviewed changes
Copy link
Contributor

@pawelrutkaq pawelrutkaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawelrutkaq pawelrutkaq pawelrutkaq requested changes

@antonkri antonkri Awaiting requested review from antonkri antonkri is a code owner

@arsibo arsibo Awaiting requested review from arsibo arsibo is a code owner

@rmaddikery rmaddikery Awaiting requested review from rmaddikery

Requested changes must be addressed to merge this pull request.

Assignees

@arkjedrz arkjedrz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arkjedrz @pawelrutkaq @rmaddikery