-
Notifications
You must be signed in to change notification settings - Fork 16
add component to requirement for future fix of meta model #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add component to requirement for future fix of meta model #524
Conversation
|
The created documentation from the pull request is available at: docu-html |
| :safety: ASIL_B | ||
| :satisfies: feat_req__feature_name__some_title | ||
| :status: invalid | ||
| :belongs_to: comp__component_name_template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems related to here, #515, first time introduce belogns_to, now in templates, and will be there anothr PR to add it to the process requirements, If would expect, that such a major chang is introduced in ONE PR, otherwise it is really difficult to follow that up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that's comes with the update of the meta model in december. The update of the picture is only for introduction of the logic interfaces in the picture which are there since a long time. See https://github.com/eclipse-score/docs-as-code/pull/331/files for introduction of the belongs_to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not see any process requirements for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is gd_req__arch_linkage_requirement. For that check this is necessary. Also the building block view requests that by "has".
| bazel_dep(name = "score_tooling", version = "1.0.2") | ||
| bazel_dep(name = "score_docs_as_code", version = "2.3.3") | ||
| bazel_dep(name = "score_docs_as_code", version = "2.3.2") | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only a temporary solution, I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The infrastructure community have decided to make official releases only from time to time and in between to use this possibility to go to later commits on the other repo. In the moment, when a new release is made, which contains the previous (and the mentioned) commits, this have to be removed and the next release have to be used in the bazel dep above instead. But currently the necessary change is after 2.3.2/2.3.3. Therefore this is the way the infrastructure team have proposed. Anyway I have set the version to 2.3.3, so the diff to the git override commit is smaller.
Add component id to requirement for future fix of meta model. Otherwise meta model update will fail in future.
Because of the cyclic dependency of between process model and docs as code repo (docs as code repo uses sphinx needs elements from process repo for integration tests, while process repo uses docs-as-code-meta model for internal examples and documentation) the changes in the meta model was introduced as as optional parameters and links. Therefore it is difficult to use the right elements. Then change will correct that, but the test is complicated, because every time the meta modell is changed, a complete rebuild (delete build folder and bazel clean is necessary). Additionally the build breaks with the first change. So the changes in the meta model must be done step by step and by revert the previous change to see the additional errors. Therefore the changes was done as different PRs in the beginning, to test any change individually. Now it is merged to one change.