Conversation
4og
requested review from
a team,
FScholPer,
antonkri,
johannes-esr and
qor-lb
as code owners
|
|
|
The created documentation from the pull request is available at: docu-html |
aschemmel-tech
left a comment
aschemmel-tech
left a comment
There was a problem hiding this comment.
see inline comments
| :satisfies: stkh_req__functional_req__base_libraries | ||
| :status: valid | ||
|
|
||
| The base libraries shall provide an operating system abstraction library that offers idiomatic interfaces for operating system functionality across supported platforms. |
There was a problem hiding this comment.
how do you want to verify that the interfaces are "idiomatic"?
| :satisfies: stkh_req__functional_req__base_libraries | ||
| :status: valid | ||
|
|
||
| The base libraries shall provide an operating system abstraction library that offers idiomatic interfaces for operating system functionality across supported platforms. |
There was a problem hiding this comment.
what is a "supported platform"? I think we agreed to only use "platform" term for the "S-CORE SW platform"
| :status: valid | ||
| :belongs_to: comp__baselibs_os | ||
|
|
||
| The OS library shall provide a C++ abstraction layer that wraps operating system interfaces using type-safe, idiomatic C++ constructs. |
| :status: valid | ||
| :belongs_to: comp__baselibs_os | ||
|
|
||
| The OS library shall provide platform-specific abstractions for Linux operating system APIs, including Linux-specific system calls and services not available in the POSIX standard. |
There was a problem hiding this comment.
what is "platform-specific"?
| :status: valid | ||
| :belongs_to: comp__baselibs_os | ||
|
|
||
| The OS library shall provide platform-specific abstractions for QNX operating system APIs, including QNX-specific system calls and services not available in the POSIX standard. |
There was a problem hiding this comment.
what is "platform-specific"?
| Static Architecture | ||
| ------------------- | ||
|
|
||
| .. comp:: OS Library |
There was a problem hiding this comment.
why not call OS Abstraction Library?
| :satisfies: stkh_req__functional_req__base_libraries | ||
| :status: valid | ||
|
|
||
| The base libraries shall provide an operating system abstraction library that offers idiomatic interfaces for operating system functionality across supported platforms. |
There was a problem hiding this comment.
Missing addition of component to the feature architecture
| :status: valid | ||
| :belongs_to: comp__baselibs_os | ||
|
|
||
| The OS library wrappers shall not add application-level logic beyond parameter type conversion and error translation. |
There was a problem hiding this comment.
"error translation" is required in comp_req__os__error_propagation. But where is the parameter type conversion required?
| :scale: 50 | ||
| :align: center | ||
|
|
||
| {{ draw_component(need(), needs) }} |
There was a problem hiding this comment.
missing interface definition (maybe three: standard, Linux-specific, QNX -specific ?)
2 participants
Fixes #2742