cr_checker: add exclusion list feature #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
fbaeuerle
force-pushed
the
fb/cr_checker_exclusion
branch
7 times, most recently
from
4621a11 to
2e86112
Compare
nradakovic
reviewed
Jan 22, 2026
cr_checker/tests/test_cr_checker.py
Outdated
| "rst", | ||
| ] | ||
| ) | ||
| def prepare_test_with_header(request, tmp_path): |
Member
There was a problem hiding this comment.
Same thing here:
Function definition with a return type annotation vs Untyped function definition. Since the approach was to use first, I would say follow the code format, but if you have strong case why you do not want to use it, speak now or be silent forever ;)
Contributor
Author
There was a problem hiding this comment.
i'm changing it for the fixtures. for the test cases i'll keep it as is, because none is using those annotations.
fbaeuerle
force-pushed
the
fb/cr_checker_exclusion
branch
from
2e86112 to
5e6af8a
Compare
Add a .bazelversion file to pin bazel version to 8.3.1. Builds fail with version 9.0.0.
Allow specifying paths that are being excluded from the copyright check. This feature is supposed to be used for source code parts taken from other open source projects that require correct attribution. The exclusion file shall contain one path to a file per entry. The check shall fail if a file listed does not exist.
Add test cases for the cr_checker core functionality. Fixes: eclipse-score#99
fbaeuerle
force-pushed
the
fb/cr_checker_exclusion
branch
from
5e6af8a to
998a84f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow specifying paths that are being excluded from the copyright check.
This feature is supposed to be used for source code parts taken from
other open source projects that require correct attribution.
The exclusion file shall contain one path to a file per entry. The check
shall fail if a file listed does not exist.
Furthermore extend the test suite to cover the core functionality as well
as the newly added functionality.
Fixes: #99