fixed cross-diagram linking and extend to class/sequence diagrams#242
Open
AAmbuj wants to merge 5 commits into
Open
fixed cross-diagram linking and extend to class/sequence diagrams#242AAmbuj wants to merge 5 commits into
AAmbuj wants to merge 5 commits into
Conversation
Contributor
AAmbuj
commented
May 22, 2026
AAmbuj
commented
- Fix class_serializer to prepend actual source filename to source_files vector, enabling the Sphinx extension to match links by .puml filename
- Extend linker to parse class (CLSD) and sequence (SEQD) FlatBuffers, extracting entities and participants for cross-diagram linking
- Register diagram names as virtual top-level aliases for title-based linking
- Extend clickable_plantuml regex to accept hyphens/dots in element identifiers
- Add linker README with architecture docs and usage instructions
AAmbuj
requested review from
LittleHuba,
castler,
hoe-jo,
limdor and
ramceb
as code owners
AAmbuj
force-pushed
the
amsh_plantuml_linker_cross_diagram_linking
branch
3 times, most recently
from
4292339 to
9d8717a
Compare
- Add 'collections' to component_kind in PEG grammar - Add Collections variant to ElementType enum and serializer mapping - Add file_identifier "COMP" to component.fbs schema - Write file identifier in component_serializer for type detection
Prepend the actual source .puml filename to the source_files vector in ClassSerializer::serialize(), enabling the linker and Sphinx extension to correlate class diagrams with their source file.
- Add class_fbs and sequence_fbs dependencies to linker BUILD - Grant linker visibility to class_fbs and sequence_fbs libraries - Detect diagram type via 4-byte file identifier (COMP/CLSD/SEQD) - Add parse_class_diagram: extract entities, FQN IDs, relationships - Add parse_sequence_diagram: extract unique participants recursively - Register diagram names as virtual top-level aliases for title-based linking - Register component FQN (id) as additional index keys - Extract relation targets as linkable elements - Deduplicate relation targets with HashSet
- Add _ALIAS_EXTENDED_RE to accept hyphens/dots in identifiers
(e.g. pkg.Class, my-component)
- Add _ALIAS_QUOTED_RE for names with spaces (wrapped in quotes)
- Refactor _format_alias_part for safe alias formatting
- Strip leading/trailing whitespace before quoting aliases
- Add {_top} window target for correct navigation in embedded SVGs
AAmbuj
force-pushed
the
amsh_plantuml_linker_cross_diagram_linking
branch
from
9d8717a to
563c263
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.