Skip to content

Conversation

@TruongQuangSB
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 15, 2025

Test Results

130 tests  ±0   130 ✅ ±0   18s ⏱️ +4s
 30 suites ±0     0 💤 ±0 
 30 files   ±0     0 ❌ ±0 

Results for commit 9127fff. ± Comparison against base commit b99626d.

This pull request removes 9 and adds 9 tests. Note that renamed tests count towards both.
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[1] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@68868328
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[2] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@544e8149
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[3] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@f6de586
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[4] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@7c847072
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[5] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@23f86d8a
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[1] TestData [input=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@13390a96, expected=multi/container-id/element-id]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[2] TestData [input=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@7497a554, expected=multi/456/123]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[1] TestData [input=Pair [first=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@2fdf7da2, second=other], expected=multi/container-id/element-id/other=other]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[2] TestData [input=Pair [first=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@584136c1, second=xxx], expected=multi/456/123/other=xxx]
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[1] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@38eb0f4d
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[2] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@74ea46e2
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[3] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@77bb48d5
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[4] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@12d5c30e
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[5] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@26586b74
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[1] TestData [input=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@b2da3a5, expected=multi/container-id/element-id]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[2] TestData [input=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@7a3a49e5, expected=multi/456/123]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[1] TestData [input=Pair [first=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@4ac19bc6, second=other], expected=multi/container-id/element-id/other=other]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[2] TestData [input=Pair [first=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@4a7db5a, second=xxx], expected=multi/456/123/other=xxx]

♻️ This comment has been updated with latest results.

@mariusheine
Copy link
Contributor

@TruongQuangSB When I open a non transformable table before opening the table overview I still see that table in the "Nicht überprüft" category. But I think this is not easily solvable, isn't it? Everything is fine when I then click on "überprüfen".

If it is not easily solvable then we should keep it as it is.

@TruongQuangSB
Copy link
Contributor Author

TruongQuangSB commented Dec 16, 2025

@TruongQuangSB When I open a non transformable table before opening the table overview I still see that table in the "Nicht überprüft" category. But I think this is not easily solvable, isn't it? Everything is fine when I then click on "überprüfen".

If it is not easily solvable then we should keep it as it is.

@mariusheine yeah, i have forgot this case. It is easily to solvable, the non rendere table will be added to nonTransformableTables . And it will be filtered by call avaiblesTable from TableOverviewPart at TableServiceImpl#getAvailableTables()

TruongQuangSB and others added 2 commits January 12, 2026 15:36
…e.properties

Co-authored-by: Marius Heine <m.heine@geprog.com>
…/feature/table/messages/Messages.java

Co-authored-by: Marius Heine <m.heine@geprog.com>
@mariusheine mariusheine merged commit b815996 into main Jan 12, 2026
21 of 23 checks passed
@mariusheine mariusheine deleted the update-table-overview-part branch January 12, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants