Conversation
kaisalmen
left a comment
kaisalmen
left a comment
There was a problem hiding this comment.
Looking good already. I have some suggestions. I did not check each and every import change and trust that VS Code's import clean-up and re-order does its job corrrectly.
We could have a direct chat tomorrow. 🙂
| @@ -16,4 +16,4 @@ | |||
|
|
|||
| // By default we export the Inversify-ready version. If you want to use the plain | |||
| // version, import from `sprotty-elk/lib/elk-layout`. | |||
There was a problem hiding this comment.
If that is still true, then you need to define the specific sub-export in the package.json.
spoenemann
left a comment
spoenemann
left a comment
There was a problem hiding this comment.
Thanks a lot for this effort @gfontorbe!
Some of the examples are currently broken: Micro-Layout Showcase, Class Diagram, Random Graph, SVG
@spoenemann this was due to how the ES standard deals with classes optional fields. ES2017 was not emitting the optional field while ES2022 is emitting optionalField=undefined. Our check for isLayoutContainer was only checking if there was a property 'layout' in the object, but never if the value was undefined. This is now fixed. |
3 participants
Migrates the packages to ESM for Sprotty 2.0.0
Upgrading dependencies will come in a future PR