Skip to content

[1738] Handle ConnectionUsage as Edge in SysON #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
adaussy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[1738] Handle ConnectionUsage as Edge in SysON #1781

adaussy wants to merge 1 commit into from
+2,506 −484

Conversation

@adaussy
Copy link
Contributor

@adaussy adaussy commented Dec 23, 2025 •
edited
Loading

Bug: #1738

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@adaussy adaussy marked this pull request as draft December 23, 2025 13:02
@adaussy adaussy force-pushed the ada/enh/1738 branch 3 times, most recently from bd90941 to d2b2590 Compare December 23, 2025 15:06
adaussy
adaussy commented Dec 23, 2025
View reviewed changes
@adaussy adaussy changed the title (Draft) [1738] Handle ConnectionUsage as Edge in SysON [1738] Handle ConnectionUsage as Edge in SysON Dec 23, 2025
@adaussy adaussy marked this pull request as ready for review December 23, 2025 15:36
@adaussy adaussy force-pushed the ada/enh/1738 branch 3 times, most recently from 0a8e852 to dbc10d9 Compare December 29, 2025 08:42
@AxelRICHARD AxelRICHARD added this to the 2026.1.0 milestone Dec 30, 2025
@AxelRICHARD AxelRICHARD linked an issue Dec 30, 2025 that may be closed by this pull request
Handle ConnectionUsage as Edge in SysON #1738
Open
AxelRICHARD
AxelRICHARD reviewed Dec 30, 2025
View reviewed changes
...agram-common-view/src/main/java/org/eclipse/syson/diagram/common/view/DescriptionFinder.java Outdated
* collection of all {@link NodeDescription}
* @return the list of description representing usages
*/
public List<NodeDescription> getMainNodeDescriptions(List<NodeDescription> allNodeDescriptions, EClass type) {
Copy link
Member

@AxelRICHARD AxelRICHARD Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand "main" here.

Copy link
Contributor Author

@adaussy adaussy Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main is to contract with "technical" Node description such as compartments.

What would you suggest ?

Copy link
Member

@AxelRICHARD AxelRICHARD Dec 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I understand now.
After discussion let's try "getConnectableNodeDescriptions".

@adaussy
[1738] Handle ConnectionUsage as Edge in SysON
584980f 
Bug: eclipse-syson#1738
Signed-off-by: Arthur Daussy <arthur.daussy@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AxelRICHARD AxelRICHARD AxelRICHARD left review comments

Assignees

No one assigned

Labels

pr: to review soon priority: high

Projects

None yet

Milestone

2026.1.0

Development

Successfully merging this pull request may close these issues.

Handle ConnectionUsage as Edge in SysON

2 participants

@adaussy @AxelRICHARD