Conversation
Motivation: The current SSL/TLS documentation is coupled to the Vert.x Net documentation. Most of the SSL/TLS configuration has been encapsulated in SSLOptions/ClientSSLOptions/ServerSSLOptions. We should provide a base documentation for configuring those options and keep the Vert.x Net configuration to a minimum and refer to the documentation of those options. Changes: Extracted the Vert.x Net client/server SSL configuration part that is generic and not coupled to this section of the documentation in a new top level section that generically documents client/server SSL options. Keep in Vert.x Net documentation the specific documentation. Added examples for ConnectOptions SSL configuration. Move the TLS upgrade documentation to the Net SSL documentation section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The current SSL/TLS documentation is coupled to the Vert.x Net documentation.
Most of the SSL/TLS configuration has been encapsulated in SSLOptions/ClientSSLOptions/ServerSSLOptions.
We should provide a base documentation for configuring those options and keep the Vert.x Net configuration to a minimum and refer to the documentation of those options.
Changes:
Extracted the Vert.x Net client/server SSL configuration part that is generic and not coupled to this section of the documentation in a new top level section that generically documents client/server SSL options.
Keep in Vert.x Net documentation the specific documentation.
Added examples for ConnectOptions SSL configuration.
Move the TLS upgrade documentation to the Net SSL documentation section.