WIP - delay locals capture from Vertx to contexts#5983
WIP - delay locals capture from Vertx to contexts#5983jponge wants to merge 1 commit intoeclipse-vertx:masterfrom
Conversation
|
what is the goal ? |
|
|
It's not necessarily meant to be merged, I'm really wondering if we need to set in stone the locals array this early in the lifetime. I've had a test in the IDE + debugger where running would fail because the |
|
the main reason the context local list is captured when creating a vertx instance, is that context are created assuming the list does not change and therefore there is an exact mapping of If |
I am wondering if we'd benefit from shifting the context local captures from the
Vertxinstance to the actual contexts creation. This involves a few allocations on duplication, but I don't think it'd be that much of a problem.One possible improvement (but I have not verified) is that it could allow new
ContextLocalinstances to be registered after aVertxcontext has been initialized.WDYT?