Remove unnecessary call to Display.syncExec in DesignPage #1348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `internal_refreshGEF_withProgress()` method is guaranteed to be called from the SWT UI thread, as it is only called from the `internal_refreshGEF()` method. This method modifies e.g. the `PageBook` (an SWT composite), which would throw an "Invalid Thread Access" when access from any other thread.
ptziegler
force-pushed
the
cleanup-design-page
branch
from
434f2ed to
baa538f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
internal_refreshGEF_withProgress()method is guaranteed to be called from the SWT UI thread, as it is only called from theinternal_refreshGEFmethod.This method modifies e.g. the
PageBook(an SWT composite), which would throw an "Invalid Thread Access" when access from any other thread.