Skip to content

Fix #1554: Configurable base URL with request-optional fallback and v…#1568

Open
harsh-k7 wants to merge 1 commit intoeclipse:masterfrom
harsh-k7:issue-1554-base-url
Open

Fix #1554: Configurable base URL with request-optional fallback and v…#1568
harsh-k7 wants to merge 1 commit intoeclipse:masterfrom
harsh-k7:issue-1554-base-url

Conversation

@harsh-k7
Copy link

Fix #1554: Configurable base URL with request-optional fallback

This PR resolves issue #1554 by introducing a clean way to generate the base URL without requiring an active servlet request context.

Key Changes:

  • Added ApplicationConfig with ovsx.server.url and ovsx.webui.url config
  • Refactored UrlUtil to use config first and fallback to request
  • Added null-safe URL validation and logging
  • Works outside servlet context and maintains backward compatibility

This allows API/UI URLs to be configured independently and fixes the original bug.

Copy link
Author

@harsh-k7 harsh-k7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix #1554: Configurable base URL with request-optional fallback and validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide a clean way to generate the base URL

1 participant