Conversation
…s left anymore, correctly output the migraiton items to be processed, delete all existing migration items from the table as migraiton is done
594d94e to
9392bfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current migration item job had various issues:
The PR does the following:
Previously the recurring job was including the registry version, however that lead to the case where the recurring job was not deleted when updating the service and there are still migrations to schedule.
These recurring jobs remain and will be continuously executed unless manually deleted as the id was tied to the registry version the app is configured with. With a stable id, it should correctly delete the recurring jobs once done.
The recurring job should only be created once with
ovsx.migrations.once-per-versionis enabled, so there is no need to also give the recurring job an id that is derived from the version.A further improvement would be to delete migration items once the scheduled migration for that item is completed.
Now it feels weird that you see migration items in the DB that have already been completed, but their status is just set to "scheduled". It seems in the past, db migrations where just deleting the items from the table with the next version.