feat(webui): add global search access across pages

[Pranav-0440]

fixes : #299

[Copilot]

Pull request overview

This PR aims to address issue #299 by making search accessible from more pages in the Web UI (so users can start a new extension search without navigating back to the home page).

Changes:

• Wrap Main route content with a DefaultApp component (intended as a global layout wrapper).
• Add a search UI (SearchBox) to both default and mobile header menu contents, gated by pageSettings.showSearch.
• Force-enable the new showSearch flag in the default webui entrypoint page settings.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File	Description
webui/src/main.tsx	Wrapes page content with DefaultApp (currently references a non-existent export).
webui/src/default/menu-content.tsx	Adds SearchBox into menu/header content for desktop and mobile, behind pageSettings.showSearch.
webui/src/default/default-app.tsx	Augments page settings with showSearch: true at the entrypoint.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

./default/default-app.tsx is the webui entrypoint that creates the React root and does not export a DefaultApp component. Importing it here and rendering <DefaultApp ...> will fail to compile (and would also introduce an entrypoint/layout coupling). Consider removing this wrapper from Main, or extracting a real layout component (exported from a dedicated module) if you need to wrap all routes.

[Copilot]

SearchBox is imported from ../components/search/search-box, but there is no components/search directory in the repo. This will fail the build; either add the new component/file in this PR or change the import to an existing search component (e.g. reuse ExtensionListSearchfield via a wrapper).

Suggested change

	import { SearchBox } from '../components/search/search-box';
	type SearchBoxProps = React.InputHTMLAttributes<HTMLInputElement>;
	export const SearchBox: FunctionComponent<SearchBoxProps> = (props) => (
	<input type='search' {...props} />
	);

[Copilot]

pageSettings is typed as PageSettings via MainContext, but PageSettings currently has no showSearch property. Accessing pageSettings.showSearch will be a TypeScript error. Add showSearch?: boolean to PageSettings (and set it in the page settings factory) or remove the flag and render the search UI unconditionally.

Suggested change

	const { user, loginProviders, pageSettings } = useContext(MainContext);
	return <>
	{pageSettings.showSearch && (
	<MobileMenuItem>
	<SearchBox />
	</MobileMenuItem>
	)}
	const { user, loginProviders } = useContext(MainContext);
	return <>
	<MobileMenuItem>
	<SearchBox />
	</MobileMenuItem>

[Copilot]

Same PageSettings.showSearch type issue as above: PageSettings does not define showSearch, so this will not type-check until the interface is updated (or the flag is removed).

[Copilot]

There is trailing whitespace after </MobileMenuItem> which may fail lint/format checks. Please remove the extra spaces.

Suggested change

	</MobileMenuItem>
	</MobileMenuItem>

[Copilot]

showSearch: true is being added ad-hoc here rather than being part of the PageSettings contract returned by createPageSettings. If showSearch is intended to be a supported setting, add it to the PageSettings interface and populate it inside createPageSettings so all consumers can rely on the same typed shape.

Suggested change

	const pageSettings = {
	...createPageSettings(prefersDarkMode, service.serverUrl, getServerVersion()),
	showSearch: true
	};
	const pageSettings = createPageSettings(prefersDarkMode, service.serverUrl, getServerVersion());

[netomi]

thanks for your contribution, please sign the ECA as outlined here https://api.eclipse.org/git/eca/status/gh/eclipse/openvsx/1595.

[Pranav-0440]

thanks for your contribution, please sign the ECA as outlined here https://api.eclipse.org/git/eca/status/gh/eclipse/openvsx/1595.

This problem occurs when signing in.