Conversation
The line height calculation used a hardcoded 1.2× multiplier on top of ascent/descent, ignoring the font's own `sTypoLineGap`. This produced spacing that didn't respect font design intent. Include `lineGap` in the text height calculation and change the default `lineHeight` multiplier from `1.2` to `1`. Line spacing now follows the font's vertical metrics directly. The previous behavior can be restored by adjusting the `lineHeight` property (e.g., `lineHeight: 1.2`). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The line height calculation used a hardcoded 1.2× multiplier on top of ascent/descent, ignoring the font's own
sTypoLineGap. This produced spacing that didn't respect font design intent.Include
lineGapin the text height calculation and change the defaultlineHeightmultiplier from1.2to1. Line spacing now follows the font's vertical metrics directly. The previous behavior can be restored by adjusting thelineHeightproperty (e.g.,lineHeight: 1.2).