Skip to content

Implement encoding for currently known atmospheric composition fields#184

Open
tweska wants to merge 2 commits into
developfrom
feature/mars2grib-chem
Open

Implement encoding for currently known atmospheric composition fields#184
tweska wants to merge 2 commits into
developfrom
feature/mars2grib-chem

Conversation

@tweska
Copy link
Copy Markdown
Member

@tweska tweska commented Mar 17, 2026

This PR implements encoding for fields mapped in ecmwf/multio#245

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 7.14286% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.88%. Comparing base (89bc959) to head (1ff114d).

Files with missing lines Patch % Lines
.../backend/concepts/composition/compositionMatcher.h 12.90% 27 Missing ⚠️
...backend/concepts/composition/compositionEncoding.h 0.00% 9 Missing ⚠️
...kit/mars2grib/backend/deductions/firstWavelength.h 0.00% 8 Missing ⚠️
src/metkit/mars2grib/backend/deductions/chemId.h 0.00% 4 Missing ⚠️
...it/mars2grib/backend/concepts/level/levelMatcher.h 0.00% 3 Missing ⚠️
...ackend/concepts/point-in-time/pointInTimeMatcher.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #184      +/-   ##
===========================================
- Coverage    62.08%   61.88%   -0.20%     
===========================================
  Files          303      304       +1     
  Lines        11689    11729      +40     
  Branches      1050     1049       -1     
===========================================
+ Hits          7257     7259       +2     
- Misses        4432     4470      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tweska tweska marked this pull request as draft March 18, 2026 12:26
@tweska
Copy link
Copy Markdown
Member Author

tweska commented Mar 18, 2026

I seem to have broken something with this PR. I'll keep this as draft until I figure out what.

It was a ) in the wrong position... :^/

@tweska tweska force-pushed the feature/mars2grib-chem branch from ab4868e to 4143b4c Compare March 18, 2026 16:25
@tweska tweska marked this pull request as ready for review March 18, 2026 16:40
Comment thread src/metkit/mars2grib/backend/concepts/composition/compositionEncoding.h Outdated
@tweska tweska force-pushed the feature/mars2grib-chem branch 2 times, most recently from 1c91323 to 423d1a2 Compare March 20, 2026 09:31
@tweska tweska force-pushed the feature/mars2grib-chem branch 2 times, most recently from 544403b to e5774b6 Compare March 30, 2026 10:01
@MircoValentiniECMWF
Copy link
Copy Markdown
Contributor

Now seems ok. Thanks

@tweska tweska force-pushed the feature/mars2grib-chem branch from e4de56d to d0ba630 Compare April 23, 2026 12:24
@tweska tweska force-pushed the feature/mars2grib-chem branch 3 times, most recently from 8d05389 to d34aac1 Compare May 6, 2026 08:20
@tweska tweska changed the title Implement encoding for currently known CAMS fields Implement encoding for currently known atmospheric composition fields May 6, 2026
@tweska tweska force-pushed the feature/mars2grib-chem branch from d34aac1 to 153768a Compare May 6, 2026 08:21
tweska added 2 commits May 11, 2026 12:57
- Add handling of atmospheric composition params in composition concept
- Add new atmospheric composition params to point-in-time and level matchers
- Add chemId deduction
- Add firstWavelength deduction
- Remove constituentType deduction
@tweska tweska force-pushed the feature/mars2grib-chem branch from 92e2ba6 to 1ff114d Compare May 11, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants