Fix passing through misc keys in encode-mtg2#275
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #275 +/- ##
===========================================
- Coverage 33.21% 33.21% -0.01%
===========================================
Files 374 374
Lines 41063 41061 -2
Branches 1701 1703 +2
===========================================
- Hits 13638 13637 -1
+ Misses 27425 27424 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes forwarding of misc-* metadata from MultIO’s encode-mtg2 action into metkit’s mars2grib encoder by dumping the misc record without its misc- key prefix, ensuring those keys are interpreted correctly by mars2grib.
Changes:
- Switch misc configuration generation from
dumpRecord(...)todumpUnscopedRecord(...)somisc-*keys arrive at mars2grib with the expected key names. - Remove unused (mapped) mars/misc
LocalConfigurationdumps inexecuteImpl. - Remove a stale TODO related to writing mapped metadata into the output message header.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d6bda5f to
7d9b19a
Compare
dsarmany
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All keys with "misc-" prefix never made it properly to the mars2grib.
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-275