fix: prevent intermittent proxy file missing errors in EcotoneLite tests#648
Merged
fix: prevent intermittent proxy file missing errors in EcotoneLite tests#648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change proposed?
EcotoneLite tests intermittently fail in CI with
Failed opening required '/tmp/ecotone/.../ProxyFile.php'errors. This happens becauseProxyFactory::dumpFile()silently ignoresfile_put_contentsandrenamefailures, then proceeds torequirea file that was never created.Description of Changes
dumpFile():file_put_contentsandrenamenow throwConfigurationExceptionon failure instead of silently continuing. Temp files are cleaned up on rename failure.loadProxyClass(): After initial proxy generation, if the file doesn't exist (stale stat cache or skipped generation), clears PHP stat cache and retries with forced overwrite beforerequire.Pull Request Contribution Terms