refactor(dataset-store): extract amp-providers-registry crate
#1564
+1,025
−347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiyasmohd
changed the title
amp-providers-registry crate
LNSD
reviewed
Jan 16, 2026
shiyasmohd
force-pushed
the
shiyasmohd/amp-providers-registry
branch
3 times, most recently
from
347801d to
275a524
Compare
shiyasmohd
force-pushed
the
shiyasmohd/amp-providers-registry
branch
from
275a524 to
2e76ee7
Compare
Contributor
Author
|
@LNSD PR is ready for review now. |
LNSD
requested changes
Jan 19, 2026
Contributor
LNSD
left a comment
LNSD
left a comment
There was a problem hiding this comment.
This is a huge PR. It is too much risk to merge it as is.
Can you split it into two separate PRs?
- PR 1: the new providers-registry crate + the raw dataset kind type in datasets-common
- PR 2: the dataset trait and all the associated changes.
Contributor
There was a problem hiding this comment.
Can we remove this Dataset type?
Comment on lines
+72
to
+75
| pub fn dataset( | ||
| reference: HashReference, | ||
| manifest: Manifest, | ||
| ) -> impl datasets_common::dataset::Dataset { |
Contributor
There was a problem hiding this comment.
The dataset() fn should return the extractor-specific dataset type, not the impl trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amp-providers-registrycrate fromamp-dataset-storeadmin-apito useDatasetsRegistrydirectly for registry operationsDatasettraitDatasettrait indatasets-commonDatasetWithFunctionstrait for UDF supported datasetsJsUdffromcommontojs-runtimeudfmodule re-exports indatasets-commonDatasettraitCloses #1558