Conversation
Bumps the npm_and_yarn group with 1 update in the / directory: [qs](https://github.com/ljharb/qs). Updates `qs` from 6.13.0 to 6.14.1 - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.13.0...v6.14.1) --- updated-dependencies: - dependency-name: qs dependency-version: 6.14.1 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Pull request overview
This PR claims to bump the qs dependency from version 6.13.0 to 6.14.1 as part of a security update. However, the actual changes show an update to the express package from version 4.21.2 to 4.22.1. The package-lock.json reveals that qs 6.14.1 is being introduced as a nested dependency within the express package, which explains the indirect update mechanism.
Key Changes:
- Express package version updated from ^4.21.2 to ^4.22.1 in both package.json and package-lock.json
- qs version 6.14.1 added as a nested dependency under express in package-lock.json
- Multiple express dependencies updated to use tilde (~) version ranges instead of exact versions
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates express dependency version from ^4.21.2 to ^4.22.1 |
| package-lock.json | Updates express to 4.22.1 with nested qs 6.14.1 dependency and adjusts version ranges for express sub-dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "dependencies": { | ||
| "@octokit/core": "^6.1.2", | ||
| "express": "^4.21.2" | ||
| "express": "^4.22.1" |
There was a problem hiding this comment.
This appears to be a version downgrade rather than an upgrade. The express package is being changed from version 4.21.2 to 4.22.1, but 4.21.2 is actually older than 4.22.1 based on semantic versioning. However, this contradicts the PR description which states this is a bump of the qs dependency from 6.13.0 to 6.14.1. The package-lock.json shows that qs 6.14.1 is being added as a nested dependency under express, but the express version change itself needs verification to ensure 4.22.1 is the correct and intended version.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
Co-authored-by: edinc <4791281+edinc@users.noreply.github.com>
Complete qs security update by fixing body-parser dependency
Bumps the npm_and_yarn group with 1 update in the / directory: qs.
Updates
qsfrom 6.13.0 to 6.14.1Changelog
Sourced from qs's changelog.
Commits
3fa11a5v6.14.1a626704[Dev Deps] updatenpmignore3086902[Fix] ensure arrayLength applies to[]notation as wellfc7930e[Dev Deps] updateeslint,@ljharb/eslint-config0b06aac[Dev Deps] update@ljharb/eslint-config64951f6[Refactor]parse: extract key segment splitting helpere1bd259[Dev Deps] update@ljharb/eslint-configf4b3d39[eslint] add eslint 9 optional peer dep6e94d95[Dev Deps] updateeslint,@ljharb/eslint-config,npmignore973dc3c[actions] add workflow permissionsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.