Support spelling_language property#210
Conversation
|
You are right, it need to be added to the spec first: spec.editorconfig.org. The plugin is a implementation of the spec for Vim. |
|
Draft specification change using |
|
I don't know how the tests work, but there's a spelling_language in the specification now so here's the implementation. |
cxw42
left a comment
There was a problem hiding this comment.
LGTM! I am just requesting one change. Thanks for this PR!
|
Sure, fixed this. Just to mention, the specification is a bit vague on which territory codes are actually included, the ISO lists all of |
|
Thanks! As for two- vs. three-letter codes, I intended
to be exactly two characters, but your point is well made --- |
|
@gustaphe Spec fix open at editorconfig/specification#54 |
|
Just checking, is there anything blocking this merge? |
|
@gustaphe Apologies for the long delay! I have squashed and force-pushed your branch. There are no content changes: $ git diff --exit-code ec5a000 ca33e23 && echo SAME
SAME |
|
Style nit: I prefer ' |
Support spelling_language property
|
Sorry for the confusion --- I use Bitbucket at work and got mixed up on the PR UI for a moment. Should merge as soon as Appveyor finishes. After rebase, also no content changes (the only differences shown in the range diff are in context lines) |
I implemented the discussion in editorconfig/editorconfig#315 . Perhaps this is the wrong way around - it should be put in the standard first. But I don't know how to edit the standard, I know how to edit the implementation.
I'm currently running off my own fork, but in case the standard is updated at least this practical implementation is ready.