Refresh JWT when required to stop it expiring#114
Open
ianbarker wants to merge 4 commits intoedwellbrook:masterfrom
Open
Refresh JWT when required to stop it expiring#114ianbarker wants to merge 4 commits intoedwellbrook:masterfrom
ianbarker wants to merge 4 commits intoedwellbrook:masterfrom
Conversation
Owner
|
Hey Ian! Thanks for taking the time to put together this PR. I think this will make a great addition to the library! 😄 Could we implement this a slightly different way?
You can get the expiration date from the JWT by:
Cheers, and let me know if there's anything I can help with! |
Author
|
Ok, good idea. I'll make those changes and update the PR |
Author
|
Ok, I've updated the PR so that the token will refresh using the exp property of the JWT payload. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that a long running app's token will expire. The API docs state that the token lasts for 24h so this PR should allow a refresh every 12 hours thus stopping it expiring.