chore: BOMS-39 rename arbi-bom to orbi-bom #356
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5 to 6. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR performs a bulk update of Python dependencies and configuration files, changing team references from "arbi-bom" to "orbi-bom" along with adding a success notification feature.
- Updates Python package versions across multiple requirements files
- Renames team references from "arbi-bom" to "orbi-bom" in workflow configurations
- Adds success notification step to the upgrade workflow
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| requirements/test.txt | Updates multiple Python package versions for testing dependencies |
| requirements/pip_tools.txt | Updates pip-tools and related package versions |
| requirements/pip.txt | Updates setuptools version |
| requirements/base.txt | Updates core Python package versions and simplifies urllib3 comments |
| .github/workflows/upgrade-python-requirements.yml | Updates GitHub Actions versions, changes team name to "orbi-bom", and adds success notification |
| .github/workflows/ci.yml | Updates GitHub Actions versions for checkout and setup-python |
| .github/dependabot.yml | Changes team reviewer from "arbi-bom" to "orbi-bom" |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| subject: Upgrade python requirements workflow executed successfully in ${{github.repository}} | ||
| to: orbi-bom-upgrade-prs@2u-internal.jsmalerts.atlassian.net | ||
| from: github-actions <github-actions@edx.org> | ||
| body: Upgrade python requirements workflow executed in ${{ github.repository }}. For details see ${{ steps.createpullrequest.outputs.generated_pr }} |
There was a problem hiding this comment.
The reference to steps.createpullrequest.outputs.generated_pr is incorrect. The step that creates the pull request uses the id create-pull-request (from the hub command), not createpullrequest. This will likely result in an empty value in the notification body.
Suggested change
| body: Upgrade python requirements workflow executed in ${{ github.repository }}. For details see ${{ steps.createpullrequest.outputs.generated_pr }} | |
| body: Upgrade python requirements workflow executed in ${{ github.repository }}. For details see https://github.com/${{ github.repository }}/pulls |
Member
Author
|
Seems to be conflicted due to same branch name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced another success notification step.