fix: enforce HTTPS root redirect for conductor /list#332
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Conductor nginx site template so requests to / redirect to the Conductor root target over HTTPS, aligning root redirects with an HTTPS canonical URL.
Changes:
- Change the
/location redirect to return an absolutehttps://…URL (instead of a path-only redirect).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
This change fixes the conductor root redirect so requests to
/are redirected to an explicit HTTPS URL using a configured canonical hostname instead of a relative path or request-derived host. This prevents the HTTPS to HTTP downgrade seen by security scanners.What changed
CONDUCTOR_ROOT_REDIRECT_URL./to{{CONDUCTOR_ROOT_REDIRECT_URL}}.Why
Validation
curl -I https://masters.stage.edx.org/https://masters.stage.edx.org/list/Rollout plan
Make sure that the following steps are done before merging: