feat: claude init by nsprenkle · Pull Request #45 · edx/frontend-app-learning

nsprenkle · 2026-03-11T14:29:19Z

Add Claude related files & setup:

Adds CLAUDE.md with repo overview.
Adds validate command to run tests & build steps.
Adds configuration to allow validation to run w/out local plugin config.
Allow-lists build scripts so Claude doesn't have to ask for input when validating.

…l plugin setup

Copilot

Pull request overview

Adds Claude Code repository guidance/config and introduces a “validate” build flow intended to mirror CI without requiring private/local plugin configuration.

Changes:

Add a build:validate webpack build path and corresponding webpack config.
Add Claude Code repo docs (CLAUDE.md) and a /validate command runbook.
Configure Claude permissions allow-list for common validation commands.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`webpack.validate.config.js`	New webpack config meant to support `build:validate` with an `env.config` stub.
`package.json`	Adds `build:validate` script to run webpack with the validate config.
`CLAUDE.md`	Adds repo/architecture guidance and common developer commands for Claude Code.
`.claude/settings.json`	Allows specific shell commands for Claude-driven validation.
`.claude/commands/validate.md`	Documents the `/validate` procedure and reporting format.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

.claude/settings.json

Copilot · 2026-03-11T14:35:48Z

.claude/commands/validate.md

+## Checks to run
+
+### 1. Commit messages
+Run: `git log main..HEAD --format="%H %s"`


This repo’s CI and workflows use master as the default branch (e.g., .github/workflows/validate.yml triggers on master), but the commit-message check here uses git log main..HEAD .... That will fail or produce empty output in this repo. Update the base ref to master (or make it derive from the repo’s default branch) so commit validation works.

Suggested change

Run: `git log main..HEAD --format="%H %s"`

Run: `git log master..HEAD --format="%H %s"`

This comment is generally correct, but aren't we basing PRs off of the most recent release/ branch?

webpack.validate.config.js

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot · 2026-03-12T18:51:46Z

.claude/settings.json

+      "Bash(npm test -- --passWithNoTests)",
+      "Bash(npm run build)",
+      "Bash(npm run build:validate)",
+      "Bash(git log -1 --pretty=%B)",


/validate instructs running git log … over a commit range, but the allowlist only permits git log -1 --pretty=%B. As a result Claude will still prompt for permission when running the commit-message check. Add an allow entry for the exact git log <default-branch>..HEAD --format="%H %s" command (or adjust the validate command to use an already-allowed git invocation).

Suggested change

"Bash(git log -1 --pretty=%B)",

"Bash(git log -1 --pretty=%B)",

"Bash(git log main..HEAD --format=\"%H %s\")",

Copilot · 2026-03-12T18:51:46Z

webpack.validate.config.js

+const { merge } = require('webpack-merge');
+const prodConfig = require('./webpack.prod.config');
+


This config claims to be identical to the prod build, but it merges @openedx/frontend-build/config/webpack.prod.config instead of the repo’s ./webpack.prod.config.js (which adds customizations like copying public/static and the @src alias). Consider importing and extending the local webpack.prod.config.js so build:validate matches the actual production build output/behavior apart from the env.config stub.

Copilot · 2026-03-12T18:51:46Z

.claude/commands/validate.md

+Run all pre-PR validation checks that mirror CI, then report results.
+
+Execute the following checks **in order**, capturing output from each. Continue through all checks even if one fails — collect all failures before reporting.
+
+## Checks to run


This command says it “mirror[s] CI”, but CI runs make validate which currently executes npm run build (not npm run build:validate). Either update the wording to reflect the intentional difference, or align CI/Makefile and this command to run the same build step so local /validate results match CI more closely.

jansenk

This looks good but I have one comment and I think the copilot suggestions are valid

jansenk · 2026-03-18T14:09:07Z

.claude/commands/validate.md

+## Checks to run
+
+### 1. Commit messages
+Run: `git log main..HEAD --format="%H %s"`


This comment is generally correct, but aren't we basing PRs off of the most recent release/ branch?

nsprenkle added 6 commits March 9, 2026 10:49

feat: add initial CLAUDE.md

64e67f1

docs: add note about forks & upgrades

31bbd44

feat: add validate command to run pre-PR validation

333d512

feat: add validate command and stub config to work regardless of loca…

8fda70b

…l plugin setup

chore: add allowed npm run scripts

7fda05d

chore: add more allowed scripts to settings.json

bb5e8b7

nsprenkle requested review from Copilot, jansenk, jristau1984, michaelroytman and sundarthapa2u March 11, 2026 14:29

Copilot started reviewing on behalf of nsprenkle March 11, 2026 14:31 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

feat: add additional missing allow scripts

0ede482

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 12, 2026 18:47

Copilot started reviewing on behalf of nsprenkle March 12, 2026 18:47 View session

nsprenkle and others added 2 commits March 12, 2026 14:48

fix: update to correct config location

e5a1808

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: update path

8184ee4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Mar 12, 2026

View reviewed changes

jansenk approved these changes Mar 18, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: claude init#45

feat: claude init#45
nsprenkle wants to merge 9 commits intorelease-teakfrom
nsprenkle/claude-init

nsprenkle commented Mar 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

jansenk Mar 18, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

jansenk left a comment

Uh oh!

jansenk Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	Run: `git log main..HEAD --format="%H %s"`
	Run: `git log master..HEAD --format="%H %s"`

	"Bash(git log -1 --pretty=%B)",
	"Bash(git log -1 --pretty=%B)",
	"Bash(git log main..HEAD --format=\"%H %s\")",

		const { merge } = require('webpack-merge');
		const prodConfig = require('./webpack.prod.config');

Conversation

nsprenkle commented Mar 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

jansenk Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

jansenk left a comment

Choose a reason for hiding this comment

Uh oh!

jansenk Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants