Refactor application settings and enhance service functionalities#158
Open
efargas wants to merge 29 commits intorefactorUIfrom
Open
Refactor application settings and enhance service functionalities#158efargas wants to merge 29 commits intorefactorUIfrom
efargas wants to merge 29 commits intorefactorUIfrom
Conversation
… iteration dumps.
…, hierarchical configuration model.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…mplement LoadSettingsAsync config reload Co-authored-by: efargas <9705611+efargas@users.noreply.github.com> Agent-Logs-Url: https://github.com/efargas/S7-Tools/sessions/54ab14c5-4797-4276-a148-c99cc0b4ca79
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fix: synchronize settings writes and implement real config reload
Co-authored-by: efargas <9705611+efargas@users.noreply.github.com> Agent-Logs-Url: https://github.com/efargas/S7-Tools/sessions/7418eaa1-380d-48c5-bb6f-a071d17d2db3
fix: update tests to compile against strongly-typed settings API
….gitattributes, settings root fix Co-authored-by: efargas <9705611+efargas@users.noreply.github.com> Agent-Logs-Url: https://github.com/efargas/S7-Tools/sessions/5a16c1ca-5572-438c-852f-43adf470cd92
…t key casing, delay caching, tests Co-authored-by: efargas <9705611+efargas@users.noreply.github.com> Agent-Logs-Url: https://github.com/efargas/S7-Tools/sessions/7129b323-9bf3-47a1-9abf-30845587aa92
Apply PR review feedback: async settings write, config root fix, UI thread safety, configurable dump delays, general settings UI, binary gitattributes
…o `Dialogs/UnifiedProfileDialogService` and remove obsolete dialog, bootloader, and view model factory services.
…IBootloaderService and standardize memory region path handling.
…, logging, and dialog management across services and viewmodels.
…ing and async invocation methods.
…n path, add legacy constant, remove ISupportExternalScope Co-authored-by: efargas <9705611+efargas@users.noreply.github.com> Agent-Logs-Url: https://github.com/efargas/S7-Tools/sessions/1d734e19-4a3b-43de-94f6-8315f58f72ab
…With Co-authored-by: efargas <9705611+efargas@users.noreply.github.com> Agent-Logs-Url: https://github.com/efargas/S7-Tools/sessions/f0064106-16af-4772-9a83-972cb23351d2
fix: MemoryRegion path alignment, debounced settings saves, ISupportExternalScope cleanup
Contributor
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
Owner
Author
|
@copilot apply changes based on the comments in this thread |
Contributor
…leanup on disconnect Co-authored-by: efargas <9705611+efargas@users.noreply.github.com> Agent-Logs-Url: https://github.com/efargas/S7-Tools/sessions/44d9dd1e-b8a2-45d1-91e1-0ed96cb90f91
…move unused Plc.Adapters duplicate Co-authored-by: efargas <9705611+efargas@users.noreply.github.com> Agent-Logs-Url: https://github.com/efargas/S7-Tools/sessions/6b3076ee-61ea-4021-90c9-d79753c8857c
Fix PlcTransportAdapter: unreliable reconnect guard and leaked stream on disconnect
…I enhancements with extensive testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactorings across the codebase, focusing on interface organization, memory region profile path consistency, and enhancements for payload management and settings. The most significant changes include a large-scale reorganization of service interfaces, updates to memory region naming conventions for consistency and backward compatibility, and improvements to user settings management.
Interface and Service Refactoring:
src/S7Tools.Core/Services/Interfaces/tosrc/S7Tools.Core/Interfaces/Services/and updated namespaces accordingly for consistency and clarity. This includes interfaces such asIBootloaderService,ICentralizedTaskLogService,IJobManager,IJobScheduler,IMemoryRegionProfileService,IMemorySegmentValidator,IPathService,IPayloadProvider, andIPlcClient. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Memory Region Profile Path and Naming Consistency:
MemoryRegionstoMemoryRegionin both code and file paths, while introducing aLegacyMemoryRegionsFolderconstant for backward compatibility. [1] [2]MemoryRegionsDirectoryproperty from theIPathServiceinterface.Settings and Configuration Enhancements:
IApplicationSettingsServiceinterface to provide a strongly-typedAppSettingsproperty, simplified the API, and added methods for importing/exporting settings as JSON. TheSettingsChangedEventArgsclass was also simplified. [1] [2] [3]Payload and File Handling Improvements:
.gitattributesentry to treat.binfiles as binary, and introduced aREADME.mdin thepayloads_outdirectory describing the available compiled payloads and their usage. [1] [2]FileTreeItemViewModel.csto useEnumerateFilesfor.binand.dmpfiles, optimizing directory traversal and file filtering. [1] [2]Bootloader Payload Communication:
These changes collectively improve maintainability, user experience, and reliability across the project.