[OPTIMIZATION] Add document service for document loading#13
Closed
michaelkubina-subhh wants to merge 3 commits intoeffective-webwork:5.0.6_subhhfrom
Closed
[OPTIMIZATION] Add document service for document loading#13michaelkubina-subhh wants to merge 3 commits intoeffective-webwork:5.0.6_subhhfrom
michaelkubina-subhh wants to merge 3 commits intoeffective-webwork:5.0.6_subhhfrom
Conversation
Author
|
ich muss diesen PR doch nochmal zurückziehen...irgendwas ist mit der dependency injection nicht korrekt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hallo Chris,
diesen PR bitte zeitnah einspielen, gerne vorher einmal melden, damit wir den rückgängig machen können, falls doch etwas nicht funktioniert. Dieser PR verlagert das Laden der Dokumente in einen Service, damit ein Dokument nur initial von einem Controller geladen wird und alle anderen sich dann daran bedienen. Das bringt nochmal weitere Sekunden beim Seitenaufbau.
Viele Grüße,
Michael