-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(mock): use nano-spawn to run child process #5472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #5472 +/- ##
==========================================
- Coverage 75.88% 75.32% -0.56%
==========================================
Files 94 94
Lines 5553 5553
Branches 1177 1177
==========================================
- Hits 4214 4183 -31
- Misses 1169 1198 +29
- Partials 170 172 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
@copilot rebase |
Rebase completed successfully! The branch has been rebased on top of the latest Key changes during rebase:
The nano-spawn integration remains intact and functional after the rebase. |
Successfully replaced
childProcess.spawnSyncwithnano-spawnin the mock package's cluster functionality. Key achievements:✅ Core Integration Complete:
childProcess.spawnSyncwith asyncnano-spawn_callFunctionOnAppWorkerasync to accommodate nano-spawn's promise-based APISubprocessError✅ Rebase Complete:
nextbranch✅ Test Results:
The change introduces a breaking change where proxy methods that call
_callFunctionOnAppWorkernow return Promises instead of throwing synchronously. This affects error handling in some edge cases but maintains backward compatibility for normal usage.✅ Quality Assurance:
Fixes #5471.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.