Review of Initialization Checker

[wmdietl]

No description provided.

[Copilot]

Pull request overview

This PR refines parts of the Initialization Checker implementation, primarily by reducing expensive type/annotation work in common cases and simplifying some control flow during initialization reasoning.

Changes:

• Refactors constructor-call detection in InitializationTransfer to avoid relying on toString() of getMethodSelect().
• Adds early-return “cheap gates” and minor logic cleanups in InitializationParentAnnotatedTypeFactory to avoid unnecessary annotation/type computations.
• Simplifies initialization-tracking checks in InitializationFieldAccessTreeAnnotator and clarifies initialization determination in InitializationAnnotatedTypeFactory.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
checker/src/main/java/org/checkerframework/checker/initialization/InitializationTransfer.java	Refactors how this(...) / super(...) constructor calls are detected when computing newly-initialized fields.
checker/src/main/java/org/checkerframework/checker/initialization/InitializationParentAnnotatedTypeFactory.java	Adds fast-path returns for common cases; simplifies some path-search logic; small cleanups in initialization qualifier handling.
checker/src/main/java/org/checkerframework/checker/initialization/InitializationFieldAccessTreeAnnotator.java	Uses store-level field-initialization query instead of constructing/looking up initialized field declaration trees.
checker/src/main/java/org/checkerframework/checker/initialization/InitializationAnnotatedTypeFactory.java	Refactors “all fields initialized” computation and uses a cheaper primitive check during uninitialized-field filtering.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.