Skip to content

Fix a soundness issue due to arithmetic overflow#170

Open
Shnatsel wants to merge 2 commits into
ejmahler:masterfrom
Shnatsel:soundness
Open

Fix a soundness issue due to arithmetic overflow#170
Shnatsel wants to merge 2 commits into
ejmahler:masterfrom
Shnatsel:soundness

Conversation

@Shnatsel
Copy link
Copy Markdown

@Shnatsel Shnatsel commented May 5, 2026

The first commit adds proof-of-concept tests that trigger out-of-bounds accesses under miri. The second one applies a fix by panicking on arithmetic overflow instead of allowing buffer overflow.

This is a memory safety issue, but I don't know how relevant this is to real-world uses since the proof-of-concept requires a custom Fft trait implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant