fix: update icon role names to current EUI canonical names#6704
Open
florent-leborgne wants to merge 1 commit into
Open
fix: update icon role names to current EUI canonical names#6704florent-leborgne wants to merge 1 commit into
florent-leborgne wants to merge 1 commit into
Conversation
Contributor
Elastic Docs AI PR menuCheck the box to run an AI review for this pull request.
Powered by GitHub Agentic Workflows and docs-actions. For more information, reach out to the docs team. |
Replaces deprecated camelCase icon names with their current snake_case equivalents following the EUI icon rename in elastic/eui#9279. Old name → New name bellSlash → bell_slash checkCircle → check_circle clockCounter → clock_counter errorFilled → error_fill export → external filterInCircle → filter_in_circle minus_in_circle → minus_circle pipeBreaks → line_break playFilled → play_filled plus_in_circle → plus_circle plus_in_square → plus_square timelineWithArrow → timeline_with_arrow transitionLeftIn → transition_left_in transitionLeftOut → transition_left_out transitionTopIn → transition_top_in transitionTopOut → transition_top_out Co-authored-by: Cursor <cursoragent@cursor.com>
florent-leborgne
force-pushed
the
fix/update-icon-names-to-eui-canonical
branch
from
32fa019 to
b21ff5d
Compare
Member
|
@florent-leborgne Seems like this one is bringing over Hub commits. |
florent-leborgne
force-pushed
the
fix/update-icon-names-to-eui-canonical
branch
from
b21ff5d to
2dc68c6
Compare
Contributor
Contributor
Vale Linting ResultsSummary: 3 warnings, 2 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| explore-analyze/dashboards/create-dashboard-of-panels-with-ecommerce-data.md | 74 | Elastic.MenuArrows | Use '→' to separate menu items, not '' or '='. Example: Select Manage index → Add lifecycle policy. |
| explore-analyze/dashboards/create-dashboard-of-panels-with-ecommerce-data.md | 159 | Elastic.MenuArrows | Use '→' to separate menu items, not '' or '='. Example: Select Manage index → Add lifecycle policy. |
| solutions/security/detect-and-alert/view-detection-alert-details.md | 40 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
💡 Suggestions (2)
| File | Line | Rule | Message |
|---|---|---|---|
| explore-analyze/alerting/alerts/view-alerts.md | 89 | Elastic.WordChoice | Consider using 'turn off, silence' instead of 'mute', unless the term is in the UI. |
| solutions/observability/incident-management/view-alerts.md | 117 | Elastic.WordChoice | Consider using 'turn off, silence' instead of 'mute', unless the term is in the UI. |
The Vale linter checks documentation changes against the Elastic Docs style guide.
To use Vale locally or report issues, refer to Elastic style guide for Vale.
leemthompo
approved these changes
May 26, 2026
Member
leemthompo
left a comment
leemthompo
left a comment
There was a problem hiding this comment.
spot check on dev docs owned files lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates all
{icon}role usages in docs-content to use current EUI canonical (snake_case) names, following the icon renaming in elastic/eui#9279.The old camelCase names continue to work as aliases in docs-builder (via
EuiSvgIcons.cs), but this cleans them up at the source so the docs stay in sync with EUI naming going forward.Replacements made across 19 files:
bellSlashbell_slashcheckCirclecheck_circleclockCounterclock_countererrorFillederror_fillexportexternalfilterInCirclefilter_in_circleminus_in_circleminus_circlepipeBreaksline_breakplayFilledplay_filledplus_in_circleplus_circleplus_in_squareplus_squaretimelineWithArrowtimeline_with_arrowtransitionLeftIntransition_left_intransitionLeftOuttransition_left_outtransitionTopIntransition_top_intransitionTopOuttransition_top_outRelated: elastic/docs-builder#3378
Made with Cursor