Skip to content

Fix potential OS command injection in clean.js #3335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DongZifan wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −2
Open

Fix potential OS command injection in clean.js #3335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions preview/clean.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,20 @@ function Cleaner(token, repo, cache_dir, tmp_dir) {
'clone',
'--bare',
'--reference', `${cache_dir}/${repo_name}`,
'--',
repo, local_path])
}

const show_heads = () => {
return exec_git(['show-ref', '--heads'], { cwd: local_path });
}


const heads_to_prs = (heads) => {
return heads
.split('\n')
.reduce((acc, line) => {
const found = line.match(/^.+ refs\/heads\/((.+)_(\d+))$/);
const found = line.match(/^[a-f0-9]+\s+refs\/heads\/((?!-)([a-zA-Z0-9_.-]+)_(\d+))$/);
if (found) {
acc.push({
branch: found[1],
Expand Down Expand Up @@ -77,7 +79,7 @@ function Cleaner(token, repo, cache_dir, tmp_dir) {
const prAge = async function (pr) {
return parseInt(await exec_git(
[
"show", "--pretty=%ad", "--no-notes", "--no-patch", "--date=unix",
"show", "--pretty=%ad", "--no-notes", "--no-patch", "--date=unix","--",
pr.branch
],
{ cwd: local_path }
Expand All @@ -89,6 +91,9 @@ function Cleaner(token, repo, cache_dir, tmp_dir) {
// Just for super double ultra paranoia.
throw "Can't delete master!";
}
if (pr.branch.startsWith('-')) {
throw new Error(`Invalid branch name detected, possible argument injection: ${pr.branch}`);
}
await exec_git(
['push', 'origin', '--delete', pr.branch],
{ cwd: local_path }
Expand Down
Loading