switch sampler implementation to use sdk incubator#1006
Closed
SylvainJuge wants to merge 1 commit intoelastic:mainfrom
Closed
switch sampler implementation to use sdk incubator#1006SylvainJuge wants to merge 1 commit intoelastic:mainfrom
SylvainJuge wants to merge 1 commit intoelastic:mainfrom
Conversation
Member
Author
|
give up for now on this due to packaging issues, let's revisit that when the SDK version is GA, which hopefully is soon as declarative config spec reached 1.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sampler implementation is now included in the SDK, so we can avoid using the one in contrib and only rely on the SDK (still incubating for now, but this is the same as the one used by declarative configuration with the
composite/developmentsampler.