Conversation
Member
Author
|
New behavior tested: cd /tmp && /tmp/elastic-package-test install -z /home/marius/projects/generated_integrations/build/packages/buildkite-0.1.0.zip -v 2>&1
2026/04/08 11:13:30 WARN CommitHash is undefined, in both /home/marius/.elastic-package/version and the compiled binary, config may be out of date.
2026/04/08 11:13:30 DEBUG Enable verbose logging
2026/04/08 11:13:30 DEBUG latest version (cached): v0.122.0. Download from: https://github.com/elastic/elastic-package/releases/tag/v0.122.0 (Timestamp 2026-04-08 10:50:15.491933965 +0200 CEST)
2026/04/08 11:13:30 DEBUG Connecting with Kibana host from current profile (profile: default, host: "https://127.0.0.1:5601")
2026/04/08 11:13:30 DEBUG Validating built .zip package (path: /home/marius/projects/generated_integrations/build/packages/buildkite-0.1.0.zip)
2026/04/08 11:13:30 DEBUG Skip validation of the built .zip package
Old behavior (when package root is not found): elastic-package install -z ./projects/generated_integrations/build/packages/airtable-0.1.0.zip
2026/04/08 11:01:59 WARN CommitHash is undefined, in both /home/marius/.elastic-package/version and the compiled binary, config may be out of date.
Error: locating repository root failed: root not found: file does not exist |
mrodm
approved these changes
Apr 8, 2026
Member
Author
|
/test |
1 similar comment
Member
Author
|
/test |
Collaborator
💛 Build succeeded, but was flaky
Failed CI StepsHistory
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With elastic-package install, we identify the correct package/folder, build it and install it.
However when --zip is supplied we skip the actual usage of the repo root and its not required anywhere, making the check redundant for users that simply wants to install a zipfile having to be in our package root.
The minor change simply skips that validation at the correct location, allowing installation with
--zipfrom anywhere, no change in existing behavior.