fix(update): reject empty update payloads before calling API#76
Merged
electather merged 1 commit intomainfrom Mar 16, 2026
Merged
fix(update): reject empty update payloads before calling API#76electather merged 1 commit intomainfrom
electather merged 1 commit intomainfrom
Conversation
Track a changed boolean across optional flags in users update, request update, and the MCP users_update tool. Return an error when no optional fields are provided so the API is never called with an empty body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
changedboolean across optional flags incmd/users/update,cmd/request/update, andcmd/mcp/tools_usersUsersUpdateHandler"at least one field must be provided"error when no optional fields are set, so the API is never called with a no-op bodyIsError=truetool result (consistent with other MCP error handling in this codebase)Test plan
TestUsersUpdateEmptyPayload—users update 1with no flags returns the expected errorTestRequestUpdateEmptyPayload—request update 42 --media-type moviewith no optional fields returns the expected errorTestMCPUsersUpdateEmptyPayload— MCPusers_updatewith onlyuserIdreturns an error resultIssue
Closes #68