-
Notifications
You must be signed in to change notification settings - Fork 333
[Help wanted] PostGIS #807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tdrz
wants to merge
74
commits into
main
Choose a base branch
from
tdrz/frontend-try-postgis2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[HELP WANTED]
We are looking for help making PostGIS a reality for PGlite.
The bulk of the work has been done, the extension is built as part of the entire build process and there are even a few PostGIS test that pass! But some don't, see all of them in
packages/pglite/tests/postgis.test.ts.There are multiple issues:
Identify the missing exported functions that PostGIS is expecting from PGlite (they need to be added toWe think we have achieved this - more tests needed.postgres-pglite/pglite-wasm/included.pglite.imports).postgres-pglite/pglite-wasm/builder/Dockerfilebut some are not because pthread required functions still sneak in.Other:
a. Although
libgdalis present in the docker builder image, it is not currently used by the final extension. Something to look into.b. I've build all deps as static libs and now I am doubting that this is the right course of actions (mainly because of difficulties of also linking libgdal to the final extension).