fix: throw when package name is set to electron#1870
Merged
dsanders11 merged 1 commit intoelectron:mainfrom Feb 13, 2026
Merged
fix: throw when package name is set to electron#1870dsanders11 merged 1 commit intoelectron:mainfrom
electron#1870dsanders11 merged 1 commit intoelectron:mainfrom
Conversation
erickzhao
approved these changes
Jan 19, 2026
malept
reviewed
Jan 19, 2026
c9ab6af to
c3e7ed2
Compare
Contributor
Author
|
rebased via github as branch was outdated, needed to amend to sign the commit. |
Contributor
Author
|
hey Erick, Mark, should I keep rebasing my branch, or will it be done automatically when someone with write access decides to merge this change? |
dsanders11
approved these changes
Feb 13, 2026
Member
dsanders11
left a comment
There was a problem hiding this comment.
should I keep rebasing my branch, or will it be done automatically when someone with write access decides to merge this change?
You don't need to keep rebasing. 🙂 I'm going ahead and merging now.
|
Thanks for your contribution! 🎉 |
|
🎉 This PR is included in version 19.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
throw when package name is set to
electron.tested with leading and trailing whitespaces too for potential
.trim()but this problem only happens when it's justelectronfixes #1869