Skip to content

fix: throw when package name is set to electron#1870

Merged
dsanders11 merged 1 commit intoelectron:mainfrom
kurekszymon:main
Feb 13, 2026
Merged

fix: throw when package name is set to electron#1870
dsanders11 merged 1 commit intoelectron:mainfrom
kurekszymon:main

Conversation

@kurekszymon
Copy link
Contributor

@kurekszymon kurekszymon commented Jan 19, 2026

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
throw when package name is set to electron.
tested with leading and trailing whitespaces too for potential .trim() but this problem only happens when it's just electron

fixes #1869

@kurekszymon kurekszymon force-pushed the main branch 2 times, most recently from c9ab6af to c3e7ed2 Compare January 29, 2026 22:16
@kurekszymon
Copy link
Contributor Author

rebased via github as branch was outdated, needed to amend to sign the commit.

@kurekszymon
Copy link
Contributor Author

hey Erick, Mark,

should I keep rebasing my branch, or will it be done automatically when someone with write access decides to merge this change?

Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I keep rebasing my branch, or will it be done automatically when someone with write access decides to merge this change?

You don't need to keep rebasing. 🙂 I'm going ahead and merging now.

@dsanders11 dsanders11 merged commit 13d93d3 into electron:main Feb 13, 2026
6 checks passed
@welcome
Copy link

welcome bot commented Feb 13, 2026

Thanks for your contribution! 🎉

@electron-npm-package-publisher

🎉 This PR is included in version 19.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package's productName cannot be set to electron (macOS)

4 participants