fix: allow folders in extra-resource (#1852)#1879
Merged
erikian merged 1 commit intoelectron:mainfrom Feb 13, 2026
Merged
Conversation
Member
|
@zhujin917 thanks for the PR! The Electron org requires signed commits for all contributions, could you please do that and update your branch? |
819694b to
b9f7516
Compare
84525c0 to
13d93d3
Compare
Contributor
Author
|
Sorry for accidentally force pushing wrong commit :( |
|
Thanks for your contribution! 🎉 |
|
🎉 This PR is included in version 19.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Allow the
extraResourcefield to accept folders. Fixes #1852.As mentioned in #1852, since using
graceful-fs'sfs.promises.cpwithout options to copyextraResource, it can no longer copy folders. However, the document does not specify that theextraResourcefield cannot accept folders. Moreover, in versions v18.4.4 and earlier, it could also accept folders. Therefore, I believe this fix is appropriate.